[GitHub] [flink] chucheng92 commented on a diff in pull request #22179: [FLINK-31380][table] FLIP-297: Support enhanced show catalogs syntax

["chucheng92 (via GitHub)" <gi...@apache.org>]

chucheng92 commented on code in PR #22179:
URL: https://github.com/apache/flink/pull/22179#discussion_r1139986468


##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ShowCatalogsOperation.java:
##########
@@ -19,10 +19,27 @@
 package org.apache.flink.table.operations;
 
 /** Operation to describe a SHOW CATALOGS statement. */
-public class ShowCatalogsOperation implements ShowOperation {
+public class ShowCatalogsOperation extends SupportsShowLikeOperation {
+
+    public ShowCatalogsOperation() {

Review Comment:
   @Aitozi thanks for reviewing, default constructor is using without like. considering ShowSqlNode & ShowOperation both apply in flink-parser and hive-parser. we must let a  default constructor. because many hive show syntax not support sub-clauses. So it need a default constructor.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org