[jira] [Commented] (CASSANDRA-9265) Add checksum to saved cache files

["Daniel Chia (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14641451#comment-14641451 ] 

Daniel Chia commented on CASSANDRA-9265:
----------------------------------------

[~aweisberg] I'm interested in taking a stab at this (I've seen developers run into corrupted caches in 2.0 somewhat frequently on their dev boxes), but I'd like some guidance on where do you think we should be saving the checksums. Should we modify the saved cache file format, or store the checksums in a separate file?

It seems to me that if we're targeting 3.x, we might as well put the checksum in the same file.

> Add checksum to saved cache files
> ---------------------------------
>
>                 Key: CASSANDRA-9265
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9265
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Ariel Weisberg
>             Fix For: 3.x
>
>
> Saved caches are not covered by a checksum. We should at least emit a checksum. My suggestion is a large checksum of the whole file (convenient offline validation), and then smaller per record checksums after each record is written (possibly a subset of the incrementally maintained larger checksum).
> I wouldn't go for anything fancy to try to recover from corruption since it is just a saved cache. If corruption is detected while reading I would just have it bail out. I would rather have less code to review and test in this instance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)