You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by dbtsai <gi...@git.apache.org> on 2018/08/14 05:04:46 UTC

[GitHub] spark issue #20313: [SPARK-22974][ML] Attach attributes to output column of ...

Github user dbtsai commented on the issue:

    https://github.com/apache/spark/pull/20313
  
    LGTM. I think to have transformer framework working properly, it's required to have attributes in `CountVector`. Being said that, we should deal with the issue of allocating big attributes for sparse cases in as a separate task.
    
    Merged into master.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org