You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "David Boden (JIRA)" <ji...@codehaus.org> on 2006/08/15 19:04:49 UTC

[jira] Created: (MECLIPSE-148) EclipseOSGIManifestWriter must support jarred code as well as supporting "." on the Bundle-Classpath

EclipseOSGIManifestWriter must support jarred code as well as supporting "." on the Bundle-Classpath
----------------------------------------------------------------------------------------------------

                 Key: MECLIPSE-148
                 URL: http://jira.codehaus.org/browse/MECLIPSE-148
             Project: Maven 2.x Eclipse Plugin
          Issue Type: Improvement
          Components: PDE support
            Reporter: David Boden


We should assume that if the developer is building a jar of the code, they are going to create a bundle using the assembly plugin with an assembly.xml like this:

<assembly>
    <id>bundle</id>
    <formats>
        <format>jar</format>
    </formats>
    <includeBaseDirectory>false</includeBaseDirectory>
    <fileSets>
        <fileSet>
            <directory>src</directory>
            <includes>
                <include>**/*.properties</include>
            </includes>
            <outputDirectory>/</outputDirectory>
        </fileSet>
        <fileSet>
            <directory>.</directory>
            <includes>
                <include>plugin.xml</include>
                <include>*.properties</include>
            </includes>
            <outputDirectory>/</outputDirectory>
        </fileSet>
    </fileSets>
    <dependencySets>
        <dependencySet>
            <outputDirectory>/</outputDirectory>
            <unpack>false</unpack>
            <scope>runtime</scope>
        </dependencySet>
    </dependencySets>
</assembly>

The dependencySets bit at the bottom of the assembly.xml file adds all the dependenceies *and* the project artifact with as artifactId-version.jar (e.g. ss_base_shared-5.0.0-SNAPSHOT.jar)

We need a configuration parameter to say whether the code will be packaged within a .jar. I don't think we need to give the user an option of what the name of the jar is. If you agree, I'll implement it as a true or false switch in the configuration.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (MECLIPSE-148) EclipseOSGIManifestWriter must support jarred code as well as supporting "." on the Bundle-Classpath

Posted by "Kenney Westerhof (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MECLIPSE-148?page=comments#action_74894 ] 
            
Kenney Westerhof commented on MECLIPSE-148:
-------------------------------------------

Not sure where this happens, but you can specify excludes in the dependencySet to exclude the current project. On the other hand,
there's no harm in not having . in the classpath but a ref to the artifact.

> EclipseOSGIManifestWriter must support jarred code as well as supporting "." on the Bundle-Classpath
> ----------------------------------------------------------------------------------------------------
>
>                 Key: MECLIPSE-148
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-148
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Improvement
>          Components: PDE support
>            Reporter: David Boden
>
> We should assume that if the developer is building a jar of the code, they are going to create a bundle using the assembly plugin with an assembly.xml like this:
> <assembly>
>     <id>bundle</id>
>     <formats>
>         <format>jar</format>
>     </formats>
>     <includeBaseDirectory>false</includeBaseDirectory>
>     <fileSets>
>         <fileSet>
>             <directory>src</directory>
>             <includes>
>                 <include>**/*.properties</include>
>             </includes>
>             <outputDirectory>/</outputDirectory>
>         </fileSet>
>         <fileSet>
>             <directory>.</directory>
>             <includes>
>                 <include>plugin.xml</include>
>                 <include>*.properties</include>
>             </includes>
>             <outputDirectory>/</outputDirectory>
>         </fileSet>
>     </fileSets>
>     <dependencySets>
>         <dependencySet>
>             <outputDirectory>/</outputDirectory>
>             <unpack>false</unpack>
>             <scope>runtime</scope>
>         </dependencySet>
>     </dependencySets>
> </assembly>
> The dependencySets bit at the bottom of the assembly.xml file adds all the dependenceies *and* the project artifact with as artifactId-version.jar (e.g. ss_base_shared-5.0.0-SNAPSHOT.jar)
> We need a configuration parameter to say whether the code will be packaged within a .jar. I don't think we need to give the user an option of what the name of the jar is. If you agree, I'll implement it as a true or false switch in the configuration.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira