You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/09 11:46:42 UTC

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6820: mpfs: Remove the ddrstorage section from the OpenSBI package

pussuw commented on code in PR #6820:
URL: https://github.com/apache/incubator-nuttx/pull/6820#discussion_r941239223


##########
arch/risc-v/src/mpfs/mpfs_opensbi.c:
##########
@@ -232,15 +232,9 @@ static const struct sbi_platform platform =
 
 /* This must go into l2_scratchpad region, starting at 0x0a000000. */
 
-static sbi_scratch_holder_t g_scratches[MPFS_MAX_NUM_HARTS] \
+sbi_scratch_holder_t g_scratches[MPFS_MAX_NUM_HARTS] \
                __attribute__((section(".l2_scratchpad")));
 
-/* These stacks are used in the mpfs_opensbi_utils.S */
-
-uint8_t g_hart_stacks[SBI_PLATFORM_DEFAULT_HART_STACK_SIZE * \
-                      MPFS_HART_COUNT] \

Review Comment:
   Yes it can be removed!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org