You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/10 09:08:38 UTC
[GitHub] [flink] zentol commented on a change in pull request #16765: [FLINK-23692] Clarify text on Cancel Job confirmation buttons
zentol commented on a change in pull request #16765:
URL: https://github.com/apache/flink/pull/16765#discussion_r685836834
##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/status/job-status.component.html
##########
@@ -51,7 +51,7 @@ <h2>{{ jobDetail.name }}</h2>
<div class="operate">
<span *ngIf="statusTips">{{ statusTips }}</span>
<ng-container *ngIf="!statusTips">
- <a nz-popconfirm nzTitle="Cancel Job?" (nzOnConfirm)="cancelJob()" *ngIf="webCancelEnabled && (jobDetail.state=='RUNNING' || jobDetail.state=='CREATED' || jobDetail.state=='RESTARTING')">Cancel Job</a>
+ <a nz-popconfirm nzTitle="Cancel Job?" nzOkText="Yes" nzCancelText="No" (nzOnConfirm)="cancelJob()" *ngIf="jobDetail.state=='RUNNING' || jobDetail.state=='CREATED' || jobDetail.state=='RESTARTING'">Cancel Job</a>
Review comment:
- please revert the indentation change
- why are you removing the webCancelEnabled check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org