You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Puneet Gupta <pu...@gmail.com> on 2016/03/01 11:14:36 UTC
Re: Review Request 43929: Fixed Test cases for TestLensQueryCommands
LENS-964
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43929/
-----------------------------------------------------------
(Updated March 1, 2016, 10:14 a.m.)
Review request for lens.
Changes
-------
- Added multiple dowmload test to test case "showPersistentResultSet"
- Updated multiple fetch of Inmemory result . the second fetch is done after purging and will not return any resultset
Bugs: LENS-964
https://issues.apache.org/jira/browse/LENS-964
Repository: lens
Description
-------
Fixed Test cases for TestLensQueryCommands LENS-964
- Fixed data provider
- Fixed individual test cases ( some were very old and assumed wrongly that InMemory resultset can be read more than once, Also some changes in command outputs were accounted for in the fix)
Diffs (updated)
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 007bf34
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 45555f4
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 2de3cc1
Diff: https://reviews.apache.org/r/43929/diff/
Testing
-------
All 7 skipped test cases are running now
--------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.lens.cli.TestLensQueryCommands
Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 230.846 sec - in org.apache.lens.cli.TestLensQueryCommands
Results :
Tests run: 14, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Puneet Gupta
Re: Review Request 43929: Fixed Test cases for TestLensQueryCommands
LENS-964
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43929/
-----------------------------------------------------------
(Updated March 1, 2016, 11:34 a.m.)
Review request for lens.
Changes
-------
Fixed Checkstyle
Bugs: LENS-964
https://issues.apache.org/jira/browse/LENS-964
Repository: lens
Description
-------
Fixed Test cases for TestLensQueryCommands LENS-964
- Fixed data provider
- Fixed individual test cases ( some were very old and assumed wrongly that InMemory resultset can be read more than once, Also some changes in command outputs were accounted for in the fix)
Diffs (updated)
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 007bf34
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 45555f4
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 2de3cc1
Diff: https://reviews.apache.org/r/43929/diff/
Testing
-------
All 7 skipped test cases are running now
--------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.lens.cli.TestLensQueryCommands
Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 230.846 sec - in org.apache.lens.cli.TestLensQueryCommands
Results :
Tests run: 14, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Puneet Gupta
Re: Review Request 43929: Fixed Test cases for TestLensQueryCommands
LENS-964
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43929/#review121417
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On March 1, 2016, 10:14 a.m., Puneet Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43929/
> -----------------------------------------------------------
>
> (Updated March 1, 2016, 10:14 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-964
> https://issues.apache.org/jira/browse/LENS-964
>
>
> Repository: lens
>
>
> Description
> -------
>
> Fixed Test cases for TestLensQueryCommands LENS-964
> - Fixed data provider
> - Fixed individual test cases ( some were very old and assumed wrongly that InMemory resultset can be read more than once, Also some changes in command outputs were accounted for in the fix)
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 007bf34
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 45555f4
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 2de3cc1
>
> Diff: https://reviews.apache.org/r/43929/diff/
>
>
> Testing
> -------
>
> All 7 skipped test cases are running now
>
> --------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.lens.cli.TestLensQueryCommands
> Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 230.846 sec - in org.apache.lens.cli.TestLensQueryCommands
>
> Results :
>
> Tests run: 14, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks,
>
> Puneet Gupta
>
>