[GitHub] [airflow] potiuk commented on a change in pull request #21294: Adding missing login provider related methods from Flask-Appbuilder

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #21294:
URL: https://github.com/apache/airflow/pull/21294#discussion_r807705941



##########
File path: setup.cfg
##########
@@ -93,7 +93,7 @@ install_requires =
     deprecated>=1.2.13
     dill>=0.2.2, <0.4
     flask>=1.1.0, <2.0
-    flask-appbuilder~=3.4, <4.0.0
+    flask-appbuilder==3.4.4

Review comment:
       ```suggestion
       # We are tightly coupled with FAB version because we vendored in part of FAB code related to security manager
       # This is done as part of preparation to removing FAB as dependency, but we are not ready for it yet
       # Every we update FAB version here, please make sure that you review TODO @jhtimmins - please describe 
       # what to compare and how to sync the changes :)
       flask-appbuilder==3.4.4
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org