[jira] [Commented] (AMQ-6058) Certain VirtualTopic configurations send messages to the wrong queue

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15022888#comment-15022888 ] 

ASF GitHub Bot commented on AMQ-6058:
-------------------------------------

GitHub user czobrisky opened a pull request:

    https://github.com/apache/activemq/pull/159

    AMQ-6058 added a check to make sure the destination starts with the v…

    …irtual topic prefix.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/czobrisky/activemq AMQ-6058

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq/pull/159.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #159
    
----
commit dca6e4506eab2c6f5752085e39dd3368ead4afed
Author: Chad Zobrisky <cz...@gmail.com>
Date:   2015-11-23T19:49:02Z

    AMQ-6058 added a check to make sure the destination starts with the virtual topic prefix.

----


> Certain VirtualTopic configurations send messages to the wrong queue
> --------------------------------------------------------------------
>
>                 Key: AMQ-6058
>                 URL: https://issues.apache.org/jira/browse/AMQ-6058
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.12.1
>            Reporter: Christopher L. Shannon
>            Assignee: Christopher L. Shannon
>
> When testing out configurations of VirtualTopics I noticed some of the behavior doesn't seem quite right when using certain VirtualTopic set ups.
> Consider a VirtualTopic with the default name of {{>}} and a prefix called {{q.test.vt.*.}}  Normally the desired behavior is to only forward messages to consumers with that prefix.  For example,  if a message is published to a topic called {{mytopic}}, then the consumer would be on queue {{q.test.vt.myconsumer.mytopic}}.  
> However, I've noticed that based on the interceptor logic that uses the destination map to find matching destinations, if a higher level queue exists, such as {{q.test.>}} in this case, that queue will also receive the message.
> It seems desirable that only queues starting with the defined prefix should get the message so we should probably do a quick sanity check in the VirtualTopicInterceptor to make sure the destinations that match start with the VirtualTopic prefix defined.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)