You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/08/05 11:13:58 UTC
[GitHub] [flink] tillrohrmann commented on a change in pull request #9339:
[FLINK-13555][runtime] SlotPool fails batch slot requests immediately if
they are unfulfillable.
tillrohrmann commented on a change in pull request #9339: [FLINK-13555][runtime] SlotPool fails batch slot requests immediately if they are unfulfillable.
URL: https://github.com/apache/flink/pull/9339#discussion_r310534212
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerImpl.java
##########
@@ -311,7 +311,7 @@ public boolean registerSlotRequest(SlotRequest slotRequest) throws SlotManagerEx
// requesting the slot failed --> remove pending slot request
pendingSlotRequests.remove(slotRequest.getAllocationId());
- throw new SlotManagerException("Could not fulfill slot request " + slotRequest.getAllocationId() + '.', e);
+ throw e;
Review comment:
I think it would still be nice to add the information which slot request (`AllocationID`) failed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services