[maven-invoker-plugin] branch master updated: as default value is 0 it makes more sense to use the other ordering solution

[ol...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

olamy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-invoker-plugin.git


The following commit(s) were added to refs/heads/master by this push:
     new c790d73  as default value is 0 it makes more sense to use the other ordering solution
c790d73 is described below

commit c790d73992e59750a7264480509e7cd859746b2f
Author: olivier lamy <ol...@apache.org>
AuthorDate: Fri Sep 6 11:19:23 2019 +1000

    as default value is 0 it makes more sense to use the other ordering solution
    
    Signed-off-by: olivier lamy <ol...@apache.org>
---
 src/it/project-setup/src/it/project3/invoker.properties             | 2 +-
 .../java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java  | 6 +++---
 src/main/mdo/invocation.mdo                                         | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/it/project-setup/src/it/project3/invoker.properties b/src/it/project-setup/src/it/project3/invoker.properties
index 5cf17e6..be57c2e 100644
--- a/src/it/project-setup/src/it/project3/invoker.properties
+++ b/src/it/project-setup/src/it/project3/invoker.properties
@@ -15,4 +15,4 @@
 # specific language governing permissions and limitations
 # under the License.
 
-invoker.ordinal=1
+invoker.ordinal=100
diff --git a/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java b/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java
index da8d390..45eaf1a 100644
--- a/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java
+++ b/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java
@@ -568,8 +568,8 @@ public abstract class AbstractInvokerMojo
      * # Since plugin version 3.0.1
      * invoker.settingsFile = ../
      *
-     * # An integer value to control run order of projects. sorted in the ascending order of the ordinal.
-     * In other words, the BuildJobs with the slowest numbers will be executed first
+     * # An integer value to control run order of projects. sorted in the descending order of the ordinal.
+     * In other words, the BuildJobs with the highest numbers will be executed first
      * # Since plugin version 3.2.1
      * invoker.ordinal = 3
      * invoker.ordinal = 1
@@ -2408,7 +2408,7 @@ public abstract class AbstractInvokerMojo
         @Override
         public int compare( Object o1, Object o2 )
         {
-            return Integer.compare( ( ( BuildJob ) o1 ).getOrdinal(), ( ( BuildJob ) o2 ).getOrdinal() );
+            return Integer.compare( ( ( BuildJob ) o2 ).getOrdinal(), ( ( BuildJob ) o1 ).getOrdinal() );
         }
     }
 
diff --git a/src/main/mdo/invocation.mdo b/src/main/mdo/invocation.mdo
index a019b2d..ad8b0c4 100644
--- a/src/main/mdo/invocation.mdo
+++ b/src/main/mdo/invocation.mdo
@@ -101,7 +101,7 @@ under the License.
           <version>1.0.0</version>
           <required>false</required>
           <type>int</type>
-          <description>BuildJobs will be sorted in the ascending order of the ordinal. In other words, the BuildJobs with the slowest numbers will be executed first</description>
+          <description>BuildJobs will be sorted in the descending order of the ordinal. In other words, the BuildJobs with the highest numbers will be executed first</description>
         </field>
       </fields>
       <codeSegments>