You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/10/24 12:22:27 UTC
[GitHub] [dubbo] ShiKui-98 opened a new pull request #9111: [3.0] Optimization code of ClassUtils
ShiKui-98 opened a new pull request #9111:
URL: https://github.com/apache/dubbo/pull/9111
## What is the purpose of the change
Optimization code of ClassUtils
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9111: [3.0] Optimization code of ClassUtils
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9111:
URL: https://github.com/apache/dubbo/pull/9111#issuecomment-950320057
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9111?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9111](https://codecov.io/gh/apache/dubbo/pull/9111?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (67aa8a4) into [3.0](https://codecov.io/gh/apache/dubbo/commit/2bd54ae05492cc1a0ac8e6fcb3485cecc0c471e7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2bd54ae) will **increase** coverage by `0.90%`.
> The diff coverage is `93.54%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9111/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9111 +/- ##
============================================
+ Coverage 63.72% 64.63% +0.90%
+ Complexity 314 312 -2
============================================
Files 1149 1178 +29
Lines 48347 50684 +2337
Branches 7291 7515 +224
============================================
+ Hits 30810 32758 +1948
- Misses 14158 14354 +196
- Partials 3379 3572 +193
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...he/dubbo/common/convert/StringToByteConverter.java](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29udmVydC9TdHJpbmdUb0J5dGVDb252ZXJ0ZXIuamF2YQ==) | `66.66% <66.66%> (ø)` | |
| [...java/org/apache/dubbo/common/utils/ClassUtils.java](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQ2xhc3NVdGlscy5qYXZh) | `80.88% <95.00%> (+0.88%)` | :arrow_up: |
| [...org/apache/dubbo/common/utils/CollectionUtils.java](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQ29sbGVjdGlvblV0aWxzLmphdmE=) | `79.19% <100.00%> (+1.18%)` | :arrow_up: |
| [.../boot/actuate/endpoint/metadata/DubboMetadata.java](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hY3R1YXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vc3ByaW5nL2Jvb3QvYWN0dWF0ZS9lbmRwb2ludC9tZXRhZGF0YS9EdWJib01ldGFkYXRhLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...nfigure/DubboHealthIndicatorAutoConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hY3R1YXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vc3ByaW5nL2Jvb3QvYWN0dWF0ZS9hdXRvY29uZmlndXJlL0R1YmJvSGVhbHRoSW5kaWNhdG9yQXV0b0NvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...figure/DubboEndpointMetadataAutoConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hY3R1YXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vc3ByaW5nL2Jvb3QvYWN0dWF0ZS9hdXRvY29uZmlndXJlL0R1YmJvRW5kcG9pbnRNZXRhZGF0YUF1dG9Db25maWd1cmF0aW9uLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...pring/context/event/DubboBootstrapStatedEvent.java](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0YXRlZEV2ZW50LmphdmE=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...pring/context/event/DubboBootstrapStopedEvent.java](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0b3BlZEV2ZW50LmphdmE=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...ing/context/DubboBootstrapApplicationListener.java](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcEFwcGxpY2F0aW9uTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (-60.00%)` | :arrow_down: |
| [.../DubboBootstrapStartStopListenerSpringAdapter.java](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcFN0YXJ0U3RvcExpc3RlbmVyU3ByaW5nQWRhcHRlci5qYXZh) | `42.85% <0.00%> (-57.15%)` | :arrow_down: |
| ... and [446 more](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9111?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9111?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2bd54ae...67aa8a4](https://codecov.io/gh/apache/dubbo/pull/9111?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] stone-98 commented on pull request #9111: [3.0] Optimization code of ClassUtils
Posted by GitBox <gi...@apache.org>.
stone-98 commented on pull request #9111:
URL: https://github.com/apache/dubbo/pull/9111#issuecomment-961752301
@AlbumenJ I think we can provide something like flip in the Converter interface.Can use it in a lot of places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #9111: [3.0] Optimization code of ClassUtils
Posted by GitBox <gi...@apache.org>.
AlbumenJ merged pull request #9111:
URL: https://github.com/apache/dubbo/pull/9111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] stone-98 commented on pull request #9111: [3.0] Optimization code of ClassUtils
Posted by GitBox <gi...@apache.org>.
stone-98 commented on pull request #9111:
URL: https://github.com/apache/dubbo/pull/9111#issuecomment-961752301
@AlbumenJ I think we can provide something like flip in the Converter interface.Can use it in a lot of places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] stone-98 commented on pull request #9111: [3.0] Optimization code of ClassUtils
Posted by GitBox <gi...@apache.org>.
stone-98 commented on pull request #9111:
URL: https://github.com/apache/dubbo/pull/9111#issuecomment-952064468
For the Converter interface, if I could go from sourceType to targetType, it certain can be convert from targetType to sourceType. But the Converter interface does not support it. In fact, there are corresponding application scenarios,For example, RpcUtils transforms timeout.
```java
private static long convertToNumber(Object obj, long defaultTimeout) {
long timeout = 0;
try {
if (obj instanceof String) {
timeout = Long.parseLong((String) obj);
} else if (obj instanceof Number) {
timeout = ((Number) obj).longValue();
} else {
timeout = Long.parseLong(obj.toString());
}
} catch (Exception e) {
// ignore
}
return timeout;
}
```
By the way, there is a bug that the defaultTimeout does not take effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on pull request #9111: [3.0] Optimization code of ClassUtils
Posted by GitBox <gi...@apache.org>.
AlbumenJ commented on pull request #9111:
URL: https://github.com/apache/dubbo/pull/9111#issuecomment-952721021
> For the Converter interface, if I could go from sourceType to targetType, it certain can be convert from targetType to sourceType. But the Converter interface does not support it. In fact, there are corresponding application scenarios,For example, RpcUtils transforms timeout.
>
> ```java
> private static long convertToNumber(Object obj, long defaultTimeout) {
> long timeout = 0;
> try {
> if (obj instanceof String) {
> timeout = Long.parseLong((String) obj);
> } else if (obj instanceof Number) {
> timeout = ((Number) obj).longValue();
> } else {
> timeout = Long.parseLong(obj.toString());
> }
> } catch (Exception e) {
> // ignore
> }
> return timeout;
> }
> ```
>
> By the way, there is a bug that the defaultTimeout does not take effect.
What is your opinion? Anything we could do to prevent this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] stone-98 commented on pull request #9111: [3.0] Optimization code of ClassUtils
Posted by GitBox <gi...@apache.org>.
stone-98 commented on pull request #9111:
URL: https://github.com/apache/dubbo/pull/9111#issuecomment-950932907
@AlbumenJ Checks were not successful,Test execution timed out. What do I need to do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #9111: [3.0] Optimization code of ClassUtils
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9111:
URL: https://github.com/apache/dubbo/pull/9111#issuecomment-950320057
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9111?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9111](https://codecov.io/gh/apache/dubbo/pull/9111?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (67aa8a4) into [3.0](https://codecov.io/gh/apache/dubbo/commit/2bd54ae05492cc1a0ac8e6fcb3485cecc0c471e7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2bd54ae) will **increase** coverage by `0.68%`.
> The diff coverage is `93.54%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9111/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9111 +/- ##
============================================
+ Coverage 63.72% 64.41% +0.68%
+ Complexity 314 312 -2
============================================
Files 1149 1178 +29
Lines 48347 50684 +2337
Branches 7291 7515 +224
============================================
+ Hits 30810 32646 +1836
- Misses 14158 14470 +312
- Partials 3379 3568 +189
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...he/dubbo/common/convert/StringToByteConverter.java](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29udmVydC9TdHJpbmdUb0J5dGVDb252ZXJ0ZXIuamF2YQ==) | `66.66% <66.66%> (ø)` | |
| [...java/org/apache/dubbo/common/utils/ClassUtils.java](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQ2xhc3NVdGlscy5qYXZh) | `80.88% <95.00%> (+0.88%)` | :arrow_up: |
| [...org/apache/dubbo/common/utils/CollectionUtils.java](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQ29sbGVjdGlvblV0aWxzLmphdmE=) | `79.19% <100.00%> (+1.18%)` | :arrow_up: |
| [.../boot/actuate/endpoint/metadata/DubboMetadata.java](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hY3R1YXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vc3ByaW5nL2Jvb3QvYWN0dWF0ZS9lbmRwb2ludC9tZXRhZGF0YS9EdWJib01ldGFkYXRhLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...nfigure/DubboHealthIndicatorAutoConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hY3R1YXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vc3ByaW5nL2Jvb3QvYWN0dWF0ZS9hdXRvY29uZmlndXJlL0R1YmJvSGVhbHRoSW5kaWNhdG9yQXV0b0NvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...figure/DubboEndpointMetadataAutoConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hY3R1YXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vc3ByaW5nL2Jvb3QvYWN0dWF0ZS9hdXRvY29uZmlndXJlL0R1YmJvRW5kcG9pbnRNZXRhZGF0YUF1dG9Db25maWd1cmF0aW9uLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...pring/context/event/DubboBootstrapStatedEvent.java](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0YXRlZEV2ZW50LmphdmE=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...pring/context/event/DubboBootstrapStopedEvent.java](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0b3BlZEV2ZW50LmphdmE=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...ing/context/DubboBootstrapApplicationListener.java](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcEFwcGxpY2F0aW9uTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (-60.00%)` | :arrow_down: |
| [.../DubboBootstrapStartStopListenerSpringAdapter.java](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcFN0YXJ0U3RvcExpc3RlbmVyU3ByaW5nQWRhcHRlci5qYXZh) | `42.85% <0.00%> (-57.15%)` | :arrow_down: |
| ... and [448 more](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9111?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9111?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2bd54ae...67aa8a4](https://codecov.io/gh/apache/dubbo/pull/9111?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] stone-98 commented on pull request #9111: [3.0] Optimization code of ClassUtils
Posted by GitBox <gi...@apache.org>.
stone-98 commented on pull request #9111:
URL: https://github.com/apache/dubbo/pull/9111#issuecomment-961752301
@AlbumenJ I think we can provide something like flip in the Converter interface.Can use it in a lot of places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9111: [3.0] Optimization code of ClassUtils
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9111:
URL: https://github.com/apache/dubbo/pull/9111#issuecomment-950320057
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9111?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9111](https://codecov.io/gh/apache/dubbo/pull/9111?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (67aa8a4) into [3.0](https://codecov.io/gh/apache/dubbo/commit/2bd54ae05492cc1a0ac8e6fcb3485cecc0c471e7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2bd54ae) will **increase** coverage by `0.93%`.
> The diff coverage is `93.54%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9111/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9111 +/- ##
============================================
+ Coverage 63.72% 64.66% +0.93%
+ Complexity 314 312 -2
============================================
Files 1149 1178 +29
Lines 48347 50719 +2372
Branches 7291 7542 +251
============================================
+ Hits 30810 32796 +1986
- Misses 14158 14355 +197
- Partials 3379 3568 +189
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9111?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...he/dubbo/common/convert/StringToByteConverter.java](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29udmVydC9TdHJpbmdUb0J5dGVDb252ZXJ0ZXIuamF2YQ==) | `66.66% <66.66%> (ø)` | |
| [...java/org/apache/dubbo/common/utils/ClassUtils.java](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQ2xhc3NVdGlscy5qYXZh) | `80.88% <95.00%> (+0.88%)` | :arrow_up: |
| [...org/apache/dubbo/common/utils/CollectionUtils.java](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQ29sbGVjdGlvblV0aWxzLmphdmE=) | `79.19% <100.00%> (+1.18%)` | :arrow_up: |
| [.../boot/actuate/endpoint/metadata/DubboMetadata.java](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hY3R1YXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vc3ByaW5nL2Jvb3QvYWN0dWF0ZS9lbmRwb2ludC9tZXRhZGF0YS9EdWJib01ldGFkYXRhLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...nfigure/DubboHealthIndicatorAutoConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hY3R1YXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vc3ByaW5nL2Jvb3QvYWN0dWF0ZS9hdXRvY29uZmlndXJlL0R1YmJvSGVhbHRoSW5kaWNhdG9yQXV0b0NvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...figure/DubboEndpointMetadataAutoConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hY3R1YXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vc3ByaW5nL2Jvb3QvYWN0dWF0ZS9hdXRvY29uZmlndXJlL0R1YmJvRW5kcG9pbnRNZXRhZGF0YUF1dG9Db25maWd1cmF0aW9uLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...pring/context/event/DubboBootstrapStatedEvent.java](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0YXRlZEV2ZW50LmphdmE=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...pring/context/event/DubboBootstrapStopedEvent.java](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0b3BlZEV2ZW50LmphdmE=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...ing/context/DubboBootstrapApplicationListener.java](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcEFwcGxpY2F0aW9uTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (-60.00%)` | :arrow_down: |
| [.../DubboBootstrapStartStopListenerSpringAdapter.java](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcFN0YXJ0U3RvcExpc3RlbmVyU3ByaW5nQWRhcHRlci5qYXZh) | `42.85% <0.00%> (-57.15%)` | :arrow_down: |
| ... and [435 more](https://codecov.io/gh/apache/dubbo/pull/9111/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9111?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9111?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2bd54ae...67aa8a4](https://codecov.io/gh/apache/dubbo/pull/9111?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org