You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by hw...@apache.org on 2010/09/23 18:34:50 UTC

svn commit: r1000530 - in /subversion/branches/object-model/subversion/bindings/c++: Client.cpp include/Client.h

Author: hwright
Date: Thu Sep 23 16:34:50 2010
New Revision: 1000530

URL: http://svn.apache.org/viewvc?rev=1000530&view=rev
Log:
On the object-model branch:
Move a few of the one-line overloaded wrappers to the header file (for
inlining).

* subversion/bindings/c++/Client.cpp
  (cat, checkout, commit): Remove.

* subversion/bindings/c++/include/Client.h
  (cat, checkout, commit): Implement wrappers here.

Modified:
    subversion/branches/object-model/subversion/bindings/c++/Client.cpp
    subversion/branches/object-model/subversion/bindings/c++/include/Client.h

Modified: subversion/branches/object-model/subversion/bindings/c++/Client.cpp
URL: http://svn.apache.org/viewvc/subversion/branches/object-model/subversion/bindings/c%2B%2B/Client.cpp?rev=1000530&r1=1000529&r2=1000530&view=diff
==============================================================================
--- subversion/branches/object-model/subversion/bindings/c++/Client.cpp (original)
+++ subversion/branches/object-model/subversion/bindings/c++/Client.cpp Thu Sep 23 16:34:50 2010
@@ -53,12 +53,6 @@ Client::getVersion()
 }
 
 void
-Client::cat(std::ostream &stream, const std::string &path_or_url)
-{
-  cat(stream, path_or_url, Revision::HEAD, Revision::HEAD);
-}
-
-void
 Client::cat(std::ostream &stream, const std::string &path_or_url,
     const Revision &peg_revision, const Revision &revision)
 {
@@ -71,13 +65,6 @@ Client::cat(std::ostream &stream, const 
 }
 
 Revision
-Client::checkout(const std::string &url, const std::string path)
-{
-  return checkout(url, path, Revision::HEAD, Revision::HEAD,
-                  svn_depth_infinity, false, false);
-}
-
-Revision
 Client::checkout(const std::string &url, const std::string path,
                  const Revision &peg_revision, const Revision &revision,
                  svn_depth_t depth, bool ignore_externals,
@@ -96,14 +83,6 @@ Client::checkout(const std::string &url,
 
 void
 Client::commit(const std::vector<std::string> &targets,
-               Callback::Commit &callback)
-{
-  commit(targets, svn_depth_infinity, false, false, std::vector<std::string>(),
-         PropTable(), callback);
-}
-
-void
-Client::commit(const std::vector<std::string> &targets,
                svn_depth_t depth, bool keep_locks, bool keep_changelists,
                const std::vector<std::string> &changelists,
                const PropTable &revprop_table,

Modified: subversion/branches/object-model/subversion/bindings/c++/include/Client.h
URL: http://svn.apache.org/viewvc/subversion/branches/object-model/subversion/bindings/c%2B%2B/include/Client.h?rev=1000530&r1=1000529&r2=1000530&view=diff
==============================================================================
--- subversion/branches/object-model/subversion/bindings/c++/include/Client.h (original)
+++ subversion/branches/object-model/subversion/bindings/c++/include/Client.h Thu Sep 23 16:34:50 2010
@@ -61,18 +61,29 @@ namespace SVN
 
       Version getVersion();
 
-      void cat(std::ostream &stream, const std::string &path_or_url);
+      inline void cat(std::ostream &stream, const std::string &path_or_url)
+      {
+        cat(stream, path_or_url, Revision::HEAD, Revision::HEAD);
+      }
       void cat(std::ostream &stream, const std::string &path_or_url,
                const Revision &peg_revision, const Revision &revision);
 
-      Revision checkout(const std::string &url, const std::string path);
+      inline Revision checkout(const std::string &url, const std::string path)
+      {
+        return checkout(url, path, Revision::HEAD, Revision::HEAD,
+                        svn_depth_infinity, false, false);
+      }
       Revision checkout(const std::string &url, const std::string path,
                         const Revision &peg_revisio, const Revision &revision,
                         svn_depth_t depth, bool ignore_externals,
                         bool allow_unver_obstructions);
 
-      void commit(const std::vector<std::string> &targets,
-                  Callback::Commit &callback);
+      inline void commit(const std::vector<std::string> &targets,
+                         Callback::Commit &callback)
+      {
+        commit(targets, svn_depth_infinity, false, false,
+               std::vector<std::string>(), PropTable(), callback);
+      }
       void commit(const std::vector<std::string> &targets,
                   svn_depth_t depth, bool keep_locks, bool keep_changelists,
                   const std::vector<std::string> &changelists,