You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by pivotal-jbarrett <gi...@git.apache.org> on 2017/01/21 23:08:19 UTC
[GitHub] geode pull request #350: Feature/geode 2316
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode/pull/350
Feature/geode 2316
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pivotal-jbarrett/geode feature/GEODE-2316
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/350.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #350
----
commit efdc861004a44a2a4b07cc91f3664036d6a579b5
Author: Jacob Barrett <jb...@pivotal.io>
Date: 2017-01-18T04:07:59Z
GEODE-2316: Cleanup headers in preparation for namespace change.
- Fixup headers using clang-tidy that were missed in the orginal
source cleanup.
commit a141ea425e38a508b77b2bb85587d0393fad213b
Author: Jacob Barrett <jb...@pivotal.io>
Date: 2017-01-18T22:22:48Z
GEODE-2316: Rename namespace gemfire to apache::geode::client.
commit 70b08a93bc6ef69c822f615ad817b5d2ca67a87c
Author: Jacob Barrett <jb...@pivotal.io>
Date: 2017-01-19T04:17:35Z
GEODE-2316: Renamed namespace gemfire_statistics to apache::geode::statistics.
commit f3733514afe5e889ebcae889239bc0d8f48f579b
Author: Jacob Barrett <jb...@pivotal.io>
Date: 2017-01-19T04:49:15Z
GEODE-2316: Rename some minor namespaces.
- gemfire_impl -> apache::geode::client::impl
- gemfire_log_globals -> apache::geode::log::globals
- gemfire_stats_globals -> apache::geode::statistics::globals
commit fe15647d470e13dbe8afd90e81d71b95355449a5
Author: Jacob Barrett <jb...@pivotal.io>
Date: 2017-01-20T05:32:56Z
GEODE-2316: Renamed namespace GemStone.GemFire.Cache -> Apache.Geode.Client
- GemStone.GemFire.Cache -> Apache.Geode.Client
- GemStone.GemFire -> Apache.Geode
commit cb3ed6ba6e87b617f1c3587cde266f82836f10a5
Author: Jacob Barrett <jb...@pivotal.io>
Date: 2017-01-21T01:20:31Z
GEODE-2316: Removed namespace Apache.Geode.Client.Generic.
commit b739e66470c6a1e838861971710f73d2d442c9fe
Author: Jacob Barrett <jb...@pivotal.io>
Date: 2017-01-21T05:45:40Z
GEODE-2316: Rename .NET namespace in tests and examples.
commit 14bb96297e3aa330abd1ffd81fb0caa548167643
Author: Jacob Barrett <jb...@pivotal.io>
Date: 2017-01-21T21:26:14Z
GEODE-2316: Cleanup some more namespaces.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #350: Feature/geode 2316
Posted by mmartell <gi...@git.apache.org>.
Github user mmartell commented on the issue:
https://github.com/apache/geode/pull/350
+1 on the groups of changes identified above by echobravopapa. In particular, in addition to the namespace rename, I like the switch to nested namespaces, which will be even simpler in C++17.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #350: Feature/geode 2316
Posted by pivotal-jbarrett <gi...@git.apache.org>.
Github user pivotal-jbarrett closed the pull request at:
https://github.com/apache/geode/pull/350
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #350: Feature/geode 2316
Posted by echobravopapa <gi...@git.apache.org>.
Github user echobravopapa commented on the issue:
https://github.com/apache/geode/pull/350
+1 on the renaming
+1 on marking the closing braces too
+1 modernizing the casting
+1 on the language specific consistencies
LGTM, Ship It!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---