[GitHub] [spark] hvanhovell commented on a diff in pull request #38935: [SPARK-41319][CONNECT][PYTHON] Implement `Column.{when, otherwise}` and Function `when`

[GitBox <gi...@apache.org>]

hvanhovell commented on code in PR #38935:
URL: https://github.com/apache/spark/pull/38935#discussion_r1041599340


##########
connector/connect/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -173,4 +174,18 @@ message Expression {
     // (Optional) Alias metadata expressed as a JSON map.
     optional string metadata = 3;
   }
+
+  // Case statements of the form "CASE WHEN a THEN b [WHEN c THEN d]* [ELSE e] END".
+  message CaseWhen {

Review Comment:
   Why not make this an unresolved_function? All it takes is that we add a constructor to CaseWhen.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org