You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/01 08:24:30 UTC
[GitHub] [airflow] zacharya19 opened a new pull request, #25437: Add dags_tags_filter_condition config to allow using AND closes #10724
zacharya19 opened a new pull request, #25437:
URL: https://github.com/apache/airflow/pull/25437
Allowing filtering of multiple tags using "AND" instead of "OR."
Currently, it's only a config flag, which means it's static per server and not per user. In the future, we should add a UI select box.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #25437: Add dags_tags_filter_condition config to allow using AND
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #25437:
URL: https://github.com/apache/airflow/pull/25437#issuecomment-1248776595
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on a diff in pull request #25437: Add dags_tags_filter_condition config to allow using AND closes
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on code in PR #25437:
URL: https://github.com/apache/airflow/pull/25437#discussion_r934284105
##########
airflow/config_templates/default_airflow.cfg:
##########
@@ -716,6 +716,9 @@ audit_view_excluded_events = gantt,landing_times,tries,duration,calendar,graph,g
# Example: audit_view_included_events = dagrun_cleared,failed
# audit_view_included_events =
+# Logical condition for tags filtering (AND or OR).
+dags_tags_filter_condition = AND
Review Comment:
I agree. If this is something we want to support then it should be user-selected at the start with 0 config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #25437: Add dags_tags_filter_condition config to allow using AND
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #25437: Add dags_tags_filter_condition config to allow using AND
URL: https://github.com/apache/airflow/pull/25437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #25437: Add dags_tags_filter_condition config to allow using AND closes
Posted by GitBox <gi...@apache.org>.
eladkal commented on code in PR #25437:
URL: https://github.com/apache/airflow/pull/25437#discussion_r934276857
##########
airflow/config_templates/default_airflow.cfg:
##########
@@ -716,6 +716,9 @@ audit_view_excluded_events = gantt,landing_times,tries,duration,calendar,graph,g
# Example: audit_view_included_events = dagrun_cleared,failed
# audit_view_included_events =
+# Logical condition for tags filtering (AND or OR).
+dags_tags_filter_condition = AND
Review Comment:
i don't think having this as setting is the best solution.
This feels more like something that we should solve in UX level (supporting both behaviors and let user select what he wish when filtering)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #25437: Add dags_tags_filter_condition config to allow using AND closes
Posted by GitBox <gi...@apache.org>.
eladkal commented on code in PR #25437:
URL: https://github.com/apache/airflow/pull/25437#discussion_r934276857
##########
airflow/config_templates/default_airflow.cfg:
##########
@@ -716,6 +716,9 @@ audit_view_excluded_events = gantt,landing_times,tries,duration,calendar,graph,g
# Example: audit_view_included_events = dagrun_cleared,failed
# audit_view_included_events =
+# Logical condition for tags filtering (AND or OR).
+dags_tags_filter_condition = AND
Review Comment:
i don't think having this as setting is the best solution.
This feels more like something that we should solve in UX level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] zacharya19 commented on a diff in pull request #25437: Add dags_tags_filter_condition config to allow using AND closes
Posted by GitBox <gi...@apache.org>.
zacharya19 commented on code in PR #25437:
URL: https://github.com/apache/airflow/pull/25437#discussion_r934283335
##########
airflow/config_templates/default_airflow.cfg:
##########
@@ -716,6 +716,9 @@ audit_view_excluded_events = gantt,landing_times,tries,duration,calendar,graph,g
# Example: audit_view_included_events = dagrun_cleared,failed
# audit_view_included_events =
+# Logical condition for tags filtering (AND or OR).
+dags_tags_filter_condition = AND
Review Comment:
I agree; see my comments here: https://github.com/apache/airflow/issues/10724#issuecomment-687609559
The idea is to have a config as the default behavior (which should be OR to be backward compatible) and add a UI select box, but I don't have time to work on the UI (and it has changed a lot since I worked on it...), so I want to get this feature in and then maybe someone else could add the UI part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org