[jira] Commented: (HDFS-1563) create(file, true) appears to be violating atomicity

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12975994#action_12975994 ] 

Hadoop QA commented on HDFS-1563:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12467154/unittest.diff
  against trunk revision 1053214.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    -1 release audit.  The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings).

    -1 core tests.  The patch failed these core unit tests:
                  org.apache.hadoop.hdfs.server.datanode.TestBlockReport
                  org.apache.hadoop.hdfs.server.namenode.TestStorageRestore
                  org.apache.hadoop.hdfs.TestFileConcurrentReader
                  org.apache.hadoop.hdfs.TestLocalDFS

    -1 contrib tests.  The patch failed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/59//testReport/
Release audit warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/59//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/59//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/59//console

This message is automatically generated.

> create(file, true) appears to be violating atomicity
> ----------------------------------------------------
>
>                 Key: HDFS-1563
>                 URL: https://issues.apache.org/jira/browse/HDFS-1563
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.20.1
>            Reporter: Guanghao Shen
>            Assignee: dhruba borthakur
>         Attachments: unittest.diff
>
>
> Will upload a unittest to reveal this bug.
> In a word, when a thread is doing create(file, true) on existing file, there are chances that another thread will get 'false' for exists(file) during the period.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.