You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/04/19 20:00:16 UTC

[GitHub] [helix] micahstubbs commented on pull request #2054: upgrade helix-front to Angular 13

micahstubbs commented on PR #2054:
URL: https://github.com/apache/helix/pull/2054#issuecomment-1103062360

   This PR is currently work in progress. There is a known build failure in the `yarn build` script, documented by two existing Angular community StackOverflow questions:
   
   - [Mixins / Webpack issues after upgrading to Angular 13](https://stackoverflow.com/questions/71287728/mixins-webpack-issues-after-upgrading-to-angular-13)
   - [editor.component.scss:17:100: ERROR: Unterminated string token - Angular + Scss](https://stackoverflow.com/questions/71916458/editor-component-scss17100-error-unterminated-string-token-angular-scss)
   
   I think this is an issue with the way that the scss styles files are being bundled and converted to css.  My guess is that something with sass changed across the version updates that requires a config or code change that this PR doesn't have yet.  Any advice on this problem will be most welcome. I am actively researching this build issue. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org