You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org> on 2008/08/11 19:00:44 UTC

[jira] Created: (QPID-1230) Broker contains duplicated mock object functionality and tests.

Broker contains duplicated mock object functionality and tests.
---------------------------------------------------------------

                 Key: QPID-1230
                 URL: https://issues.apache.org/jira/browse/QPID-1230
             Project: Qpid
          Issue Type: Task
          Components: Java Tests
    Affects Versions: M3
            Reporter: Martin Ritchie
            Priority: Minor


Summary:

As a result of QPID-1229 there is a large amount of duplication that we should resolve in our tests and mock objects.

AckTest and AcknowledgeTest

AckTest contains publishMessage as does BrokerBaseCase.
The version in AckTest registers a subscriber first but the BrokerBaseCase does not.

We have 10 anonymous implementations of MessagePublishInfo, this is a prime candidate for a mock object.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (QPID-1230) Broker contains duplicated mock object functionality and tests.

Posted by "Marnie McCormack (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marnie McCormack updated QPID-1230:
-----------------------------------

    Fix Version/s:     (was: M4)

Moving items not being worked on for M4 afaik out of scope

> Broker contains duplicated mock object functionality and tests.
> ---------------------------------------------------------------
>
>                 Key: QPID-1230
>                 URL: https://issues.apache.org/jira/browse/QPID-1230
>             Project: Qpid
>          Issue Type: Task
>          Components: Java Tests
>    Affects Versions: M3
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>            Priority: Minor
>
> Summary:
> As a result of QPID-1229 there is a large amount of duplication that we should resolve in our tests and mock objects.
> AckTest and AcknowledgeTest
> AckTest contains publishMessage as does BrokerBaseCase.
> The version in AckTest registers a subscriber first but the BrokerBaseCase does not.
> We have 10 anonymous implementations of MessagePublishInfo, this is a prime candidate for a mock object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (QPID-1230) Refactor MockProtocolSession and replace with InternalTestProtocolSession

Posted by "Marnie McCormack (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marnie McCormack updated QPID-1230:
-----------------------------------

    Description: 
Summary:

As a result of QPID-1229 there is a large amount of duplication that we should resolve in our tests and mock objects.

This JIRA is specific to the removal of MockProtocolSession and replacement of refs to it with InternalTestProtocolSession instead.




  was:
Summary:

As a result of QPID-1229 there is a large amount of duplication that we should resolve in our tests and mock objects.

AckTest and AcknowledgeTest

AckTest contains publishMessage as does BrokerBaseCase.
The version in AckTest registers a subscriber first but the BrokerBaseCase does not.

We have 10 anonymous implementations of MessagePublishInfo, this is a prime candidate for a mock object.



        Summary: Refactor MockProtocolSession and replace with InternalTestProtocolSession  (was: Broker contains duplicated mock object functionality and tests.)

Updating JIRA to reflect specific task, and reviewing work

> Refactor MockProtocolSession and replace with InternalTestProtocolSession
> -------------------------------------------------------------------------
>
>                 Key: QPID-1230
>                 URL: https://issues.apache.org/jira/browse/QPID-1230
>             Project: Qpid
>          Issue Type: Task
>          Components: Java Tests
>    Affects Versions: M3
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>            Priority: Minor
>
> Summary:
> As a result of QPID-1229 there is a large amount of duplication that we should resolve in our tests and mock objects.
> This JIRA is specific to the removal of MockProtocolSession and replacement of refs to it with InternalTestProtocolSession instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Assigned: (QPID-1230) Broker contains duplicated mock object functionality and tests.

Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Ritchie reassigned QPID-1230:
------------------------------------

    Assignee: Martin Ritchie

> Broker contains duplicated mock object functionality and tests.
> ---------------------------------------------------------------
>
>                 Key: QPID-1230
>                 URL: https://issues.apache.org/jira/browse/QPID-1230
>             Project: Qpid
>          Issue Type: Task
>          Components: Java Tests
>    Affects Versions: M3
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>            Priority: Minor
>
> Summary:
> As a result of QPID-1229 there is a large amount of duplication that we should resolve in our tests and mock objects.
> AckTest and AcknowledgeTest
> AckTest contains publishMessage as does BrokerBaseCase.
> The version in AckTest registers a subscriber first but the BrokerBaseCase does not.
> We have 10 anonymous implementations of MessagePublishInfo, this is a prime candidate for a mock object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (QPID-1230) Refactor MockProtocolSession and replace with InternalTestProtocolSession

Posted by "Marnie McCormack (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marnie McCormack resolved QPID-1230.
------------------------------------

       Resolution: Fixed
    Fix Version/s: 0.6

Reviewed changes & all ok.

> Refactor MockProtocolSession and replace with InternalTestProtocolSession
> -------------------------------------------------------------------------
>
>                 Key: QPID-1230
>                 URL: https://issues.apache.org/jira/browse/QPID-1230
>             Project: Qpid
>          Issue Type: Task
>          Components: Java Tests
>    Affects Versions: M3
>            Reporter: Martin Ritchie
>            Assignee: Martin Ritchie
>            Priority: Minor
>             Fix For: 0.6
>
>
> Summary:
> As a result of QPID-1229 there is a large amount of duplication that we should resolve in our tests and mock objects.
> This JIRA is specific to the removal of MockProtocolSession and replacement of refs to it with InternalTestProtocolSession instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org