You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2013/09/18 13:25:48 UTC
Review Request 14199: Adding missing test cases: Snapshots Improvement
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14199/
-----------------------------------------------------------
Review request for cloudstack and Prasanna Santhanam.
Repository: cloudstack-git
Description
-------
Adding 5 missing test cases.
Change in asyncJobMgr.py >> the method "make_request" in cloudstackConnection does not exist now. Replaced it by "marvin_request". Checked running async jobs with this change. Works correctly.
Diffs
-----
test/integration/component/test_snapshots_improvement.py PRE-CREATION
tools/marvin/marvin/asyncJobMgr.py 25818a6
Diff: https://reviews.apache.org/r/14199/diff/
Testing
-------
Tested locally.
Thanks,
Gaurav Aradhye
Re: Review Request 14199: Adding missing test cases: Snapshots Improvement
Posted by Girish Shilamkar <gi...@clogeny.com>.
> On Oct. 23, 2013, 8:57 a.m., Prasanna Santhanam wrote:
> > Patch will require few changes before applying to master. Can you please rebase against latest?
The patch applies cleanly to master.
- Girish
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14199/#review27371
-----------------------------------------------------------
On Oct. 28, 2013, 5:53 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14199/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2013, 5:53 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar and suresh sadhu.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding 5 missing test cases.
> Change in asyncJobMgr.py >> the method "make_request" in cloudstackConnection does not exist now. Replaced it by "marvin_request". Checked running async jobs with this change. Works correctly.
>
>
> Diffs
> -----
>
> test/integration/component/test_snapshots_improvement.py PRE-CREATION
> tools/marvin/marvin/asyncJobMgr.py 25818a6
>
> Diff: https://reviews.apache.org/r/14199/diff/
>
>
> Testing
> -------
>
> Tested locally on KVM Advanced setup.
>
> test_01_concurrent_snapshots_live_migrate (test_snapshots_improvement.TestCreateSnapshot)
> Test perform concurrent snapshots and migrate the vm from one host ... ok
> test_02_stop_vm_concurrent_snapshots (test_snapshots_improvement.TestCreateSnapshot)
> Test stop running VM while performing concurrent snapshot on volume ... ok
> test_03_concurrent_snapshots_create_template (test_snapshots_improvement.TestCreateSnapshot)
> Test while parent concurrent snapshot job in progress,create ... ok
> test_04_concurrent_snapshots_create_volume (test_snapshots_improvement.TestCreateSnapshot)
> Test while parent concurrent snapshot job in progress,create volume ... ok
> test_01_snapshot_on_rootVolume (test_snapshots_improvement.TestSnapshotOnRootVolume)
> Test create VM with default cent os template and create snapshot ... ok
>
> ----------------------------------------------------------------------
> Ran 5 tests in 1420.575s
>
> OK
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 14199: Adding missing test cases: Snapshots Improvement
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14199/#review27371
-----------------------------------------------------------
Patch will require few changes before applying to master. Can you please rebase against latest?
- Prasanna Santhanam
On Oct. 11, 2013, 8:06 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14199/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2013, 8:06 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding 5 missing test cases.
> Change in asyncJobMgr.py >> the method "make_request" in cloudstackConnection does not exist now. Replaced it by "marvin_request". Checked running async jobs with this change. Works correctly.
>
>
> Diffs
> -----
>
> test/integration/component/test_snapshots_improvement.py PRE-CREATION
> tools/marvin/marvin/asyncJobMgr.py 25818a6
>
> Diff: https://reviews.apache.org/r/14199/diff/
>
>
> Testing
> -------
>
> Tested locally on KVM Advanced setup.
>
> test_01_concurrent_snapshots_live_migrate (test_snapshots_improvement.TestCreateSnapshot)
> Test perform concurrent snapshots and migrate the vm from one host ... ok
> test_02_stop_vm_concurrent_snapshots (test_snapshots_improvement.TestCreateSnapshot)
> Test stop running VM while performing concurrent snapshot on volume ... ok
> test_03_concurrent_snapshots_create_template (test_snapshots_improvement.TestCreateSnapshot)
> Test while parent concurrent snapshot job in progress,create ... ok
> test_04_concurrent_snapshots_create_volume (test_snapshots_improvement.TestCreateSnapshot)
> Test while parent concurrent snapshot job in progress,create volume ... ok
> test_01_snapshot_on_rootVolume (test_snapshots_improvement.TestSnapshotOnRootVolume)
> Test create VM with default cent os template and create snapshot ... ok
>
> ----------------------------------------------------------------------
> Ran 5 tests in 1420.575s
>
> OK
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 14199: Adding missing test cases: Snapshots Improvement
Posted by Gaurav Aradhye <ga...@clogeny.com>.
> On Nov. 4, 2013, 2:43 p.m., SrikanteswaraRao Talluri wrote:
> > is_snapshot_on_nfs method is returning error. NFS export path is wrongly framed in utils.py
> >
> > Cmd: mount -t nfs 10.147.28.7/export/home/talluri/vmware.campo/secondary /mnt/tmp via Host: 10.147.38.207} {returns: ["mount.nfs: remote share not in 'host:dir' format"]}
Hi Talluri,
This issue arises when the Image url is not in proper format. As you can see, in above URL, colon is missing after the ip address. I had already logged this issue here: https://issues.apache.org/jira/browse/CLOUDSTACK-4741
This issue is inconsistent and now even I am not able to reproduce it on any setup. As you have encountered this, can you reopen it and please share the details of the setup?
- Gaurav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14199/#review28090
-----------------------------------------------------------
On Oct. 31, 2013, 10:34 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14199/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2013, 10:34 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar, suresh sadhu, and SrikanteswaraRao Talluri.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding 5 missing test cases.
> Change in asyncJobMgr.py >> the method "make_request" in cloudstackConnection does not exist now. Replaced it by "marvin_request". Checked running async jobs with this change. Works correctly.
>
>
> Diffs
> -----
>
> test/integration/component/test_snapshots_improvement.py PRE-CREATION
> tools/marvin/marvin/asyncJobMgr.py 25818a6
>
> Diff: https://reviews.apache.org/r/14199/diff/
>
>
> Testing
> -------
>
> Tested locally on KVM Advanced setup.
>
> test_01_concurrent_snapshots_live_migrate (test_snapshots_improvement.TestCreateSnapshot)
> Test perform concurrent snapshots and migrate the vm from one host ... ok
> test_02_stop_vm_concurrent_snapshots (test_snapshots_improvement.TestCreateSnapshot)
> Test stop running VM while performing concurrent snapshot on volume ... ok
> test_03_concurrent_snapshots_create_template (test_snapshots_improvement.TestCreateSnapshot)
> Test while parent concurrent snapshot job in progress,create ... ok
> test_04_concurrent_snapshots_create_volume (test_snapshots_improvement.TestCreateSnapshot)
> Test while parent concurrent snapshot job in progress,create volume ... ok
> test_01_snapshot_on_rootVolume (test_snapshots_improvement.TestSnapshotOnRootVolume)
> Test create VM with default cent os template and create snapshot ... ok
>
> ----------------------------------------------------------------------
> Ran 5 tests in 1420.575s
>
> OK
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 14199: Adding missing test cases: Snapshots Improvement
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14199/#review28090
-----------------------------------------------------------
is_snapshot_on_nfs method is returning error. NFS export path is wrongly framed in utils.py
Cmd: mount -t nfs 10.147.28.7/export/home/talluri/vmware.campo/secondary /mnt/tmp via Host: 10.147.38.207} {returns: ["mount.nfs: remote share not in 'host:dir' format"]}
- SrikanteswaraRao Talluri
On Oct. 31, 2013, 5:04 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14199/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2013, 5:04 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar, suresh sadhu, and SrikanteswaraRao Talluri.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding 5 missing test cases.
> Change in asyncJobMgr.py >> the method "make_request" in cloudstackConnection does not exist now. Replaced it by "marvin_request". Checked running async jobs with this change. Works correctly.
>
>
> Diffs
> -----
>
> test/integration/component/test_snapshots_improvement.py PRE-CREATION
> tools/marvin/marvin/asyncJobMgr.py 25818a6
>
> Diff: https://reviews.apache.org/r/14199/diff/
>
>
> Testing
> -------
>
> Tested locally on KVM Advanced setup.
>
> test_01_concurrent_snapshots_live_migrate (test_snapshots_improvement.TestCreateSnapshot)
> Test perform concurrent snapshots and migrate the vm from one host ... ok
> test_02_stop_vm_concurrent_snapshots (test_snapshots_improvement.TestCreateSnapshot)
> Test stop running VM while performing concurrent snapshot on volume ... ok
> test_03_concurrent_snapshots_create_template (test_snapshots_improvement.TestCreateSnapshot)
> Test while parent concurrent snapshot job in progress,create ... ok
> test_04_concurrent_snapshots_create_volume (test_snapshots_improvement.TestCreateSnapshot)
> Test while parent concurrent snapshot job in progress,create volume ... ok
> test_01_snapshot_on_rootVolume (test_snapshots_improvement.TestSnapshotOnRootVolume)
> Test create VM with default cent os template and create snapshot ... ok
>
> ----------------------------------------------------------------------
> Ran 5 tests in 1420.575s
>
> OK
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 14199: Adding missing test cases: Snapshots Improvement
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14199/
-----------------------------------------------------------
(Updated Oct. 31, 2013, 10:34 a.m.)
Review request for cloudstack, Girish Shilamkar, suresh sadhu, and SrikanteswaraRao Talluri.
Changes
-------
Adding Talluri as reviewer.
Repository: cloudstack-git
Description
-------
Adding 5 missing test cases.
Change in asyncJobMgr.py >> the method "make_request" in cloudstackConnection does not exist now. Replaced it by "marvin_request". Checked running async jobs with this change. Works correctly.
Diffs
-----
test/integration/component/test_snapshots_improvement.py PRE-CREATION
tools/marvin/marvin/asyncJobMgr.py 25818a6
Diff: https://reviews.apache.org/r/14199/diff/
Testing
-------
Tested locally on KVM Advanced setup.
test_01_concurrent_snapshots_live_migrate (test_snapshots_improvement.TestCreateSnapshot)
Test perform concurrent snapshots and migrate the vm from one host ... ok
test_02_stop_vm_concurrent_snapshots (test_snapshots_improvement.TestCreateSnapshot)
Test stop running VM while performing concurrent snapshot on volume ... ok
test_03_concurrent_snapshots_create_template (test_snapshots_improvement.TestCreateSnapshot)
Test while parent concurrent snapshot job in progress,create ... ok
test_04_concurrent_snapshots_create_volume (test_snapshots_improvement.TestCreateSnapshot)
Test while parent concurrent snapshot job in progress,create volume ... ok
test_01_snapshot_on_rootVolume (test_snapshots_improvement.TestSnapshotOnRootVolume)
Test create VM with default cent os template and create snapshot ... ok
----------------------------------------------------------------------
Ran 5 tests in 1420.575s
OK
Thanks,
Gaurav Aradhye
Re: Review Request 14199: Adding missing test cases: Snapshots Improvement
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14199/
-----------------------------------------------------------
(Updated Oct. 28, 2013, 5:53 a.m.)
Review request for cloudstack, Girish Shilamkar and suresh sadhu.
Changes
-------
including feature reviewers
Repository: cloudstack-git
Description
-------
Adding 5 missing test cases.
Change in asyncJobMgr.py >> the method "make_request" in cloudstackConnection does not exist now. Replaced it by "marvin_request". Checked running async jobs with this change. Works correctly.
Diffs
-----
test/integration/component/test_snapshots_improvement.py PRE-CREATION
tools/marvin/marvin/asyncJobMgr.py 25818a6
Diff: https://reviews.apache.org/r/14199/diff/
Testing
-------
Tested locally on KVM Advanced setup.
test_01_concurrent_snapshots_live_migrate (test_snapshots_improvement.TestCreateSnapshot)
Test perform concurrent snapshots and migrate the vm from one host ... ok
test_02_stop_vm_concurrent_snapshots (test_snapshots_improvement.TestCreateSnapshot)
Test stop running VM while performing concurrent snapshot on volume ... ok
test_03_concurrent_snapshots_create_template (test_snapshots_improvement.TestCreateSnapshot)
Test while parent concurrent snapshot job in progress,create ... ok
test_04_concurrent_snapshots_create_volume (test_snapshots_improvement.TestCreateSnapshot)
Test while parent concurrent snapshot job in progress,create volume ... ok
test_01_snapshot_on_rootVolume (test_snapshots_improvement.TestSnapshotOnRootVolume)
Test create VM with default cent os template and create snapshot ... ok
----------------------------------------------------------------------
Ran 5 tests in 1420.575s
OK
Thanks,
Gaurav Aradhye
Re: Review Request 14199: Adding missing test cases: Snapshots Improvement
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14199/
-----------------------------------------------------------
(Updated Oct. 11, 2013, 1:36 p.m.)
Review request for cloudstack and Prasanna Santhanam.
Changes
-------
Review changes.
Repository: cloudstack-git
Description
-------
Adding 5 missing test cases.
Change in asyncJobMgr.py >> the method "make_request" in cloudstackConnection does not exist now. Replaced it by "marvin_request". Checked running async jobs with this change. Works correctly.
Diffs (updated)
-----
test/integration/component/test_snapshots_improvement.py PRE-CREATION
tools/marvin/marvin/asyncJobMgr.py 25818a6
Diff: https://reviews.apache.org/r/14199/diff/
Testing (updated)
-------
Tested locally on KVM Advanced setup.
test_01_concurrent_snapshots_live_migrate (test_snapshots_improvement.TestCreateSnapshot)
Test perform concurrent snapshots and migrate the vm from one host ... ok
test_02_stop_vm_concurrent_snapshots (test_snapshots_improvement.TestCreateSnapshot)
Test stop running VM while performing concurrent snapshot on volume ... ok
test_03_concurrent_snapshots_create_template (test_snapshots_improvement.TestCreateSnapshot)
Test while parent concurrent snapshot job in progress,create ... ok
test_04_concurrent_snapshots_create_volume (test_snapshots_improvement.TestCreateSnapshot)
Test while parent concurrent snapshot job in progress,create volume ... ok
test_01_snapshot_on_rootVolume (test_snapshots_improvement.TestSnapshotOnRootVolume)
Test create VM with default cent os template and create snapshot ... ok
----------------------------------------------------------------------
Ran 5 tests in 1420.575s
OK
Thanks,
Gaurav Aradhye
Re: Review Request 14199: Adding missing test cases: Snapshots Improvement
Posted by Gaurav Aradhye <ga...@clogeny.com>.
> On Oct. 7, 2013, 10:48 p.m., Nitin Mehta wrote:
> >
>
> Nitin Mehta wrote:
> It would be great if you could show logs of a sample run. Please also let me know if all the 5 cases are tested as well
Log Added.
> On Oct. 7, 2013, 10:48 p.m., Nitin Mehta wrote:
> > test/integration/component/test_snapshots_improvement.py, line 628
> > <https://reviews.apache.org/r/14199/diff/1/?file=353158#file353158line628>
> >
> > step 6 is happening before step 5
Changed the code so that both the steps now happen asynchronously.
- Gaurav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14199/#review26715
-----------------------------------------------------------
On Sept. 18, 2013, 4:55 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14199/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2013, 4:55 p.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding 5 missing test cases.
> Change in asyncJobMgr.py >> the method "make_request" in cloudstackConnection does not exist now. Replaced it by "marvin_request". Checked running async jobs with this change. Works correctly.
>
>
> Diffs
> -----
>
> test/integration/component/test_snapshots_improvement.py PRE-CREATION
> tools/marvin/marvin/asyncJobMgr.py 25818a6
>
> Diff: https://reviews.apache.org/r/14199/diff/
>
>
> Testing
> -------
>
> Tested locally.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 14199: Adding missing test cases: Snapshots Improvement
Posted by Nitin Mehta <ni...@citrix.com>.
> On Oct. 7, 2013, 5:18 p.m., Nitin Mehta wrote:
> >
It would be great if you could show logs of a sample run. Please also let me know if all the 5 cases are tested as well
- Nitin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14199/#review26715
-----------------------------------------------------------
On Sept. 18, 2013, 11:25 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14199/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2013, 11:25 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding 5 missing test cases.
> Change in asyncJobMgr.py >> the method "make_request" in cloudstackConnection does not exist now. Replaced it by "marvin_request". Checked running async jobs with this change. Works correctly.
>
>
> Diffs
> -----
>
> test/integration/component/test_snapshots_improvement.py PRE-CREATION
> tools/marvin/marvin/asyncJobMgr.py 25818a6
>
> Diff: https://reviews.apache.org/r/14199/diff/
>
>
> Testing
> -------
>
> Tested locally.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 14199: Adding missing test cases: Snapshots Improvement
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14199/#review26715
-----------------------------------------------------------
test/integration/component/test_snapshots_improvement.py
<https://reviews.apache.org/r/14199/#comment52037>
Do check the state of the snapshot as well.
test/integration/component/test_snapshots_improvement.py
<https://reviews.apache.org/r/14199/#comment52045>
step 6 is happening before step 5
- Nitin Mehta
On Sept. 18, 2013, 11:25 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14199/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2013, 11:25 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding 5 missing test cases.
> Change in asyncJobMgr.py >> the method "make_request" in cloudstackConnection does not exist now. Replaced it by "marvin_request". Checked running async jobs with this change. Works correctly.
>
>
> Diffs
> -----
>
> test/integration/component/test_snapshots_improvement.py PRE-CREATION
> tools/marvin/marvin/asyncJobMgr.py 25818a6
>
> Diff: https://reviews.apache.org/r/14199/diff/
>
>
> Testing
> -------
>
> Tested locally.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>