[GitHub] [iceberg] jiasheng55 commented on a change in pull request #3135: Data: Fix equality delete set save DATE/TIMESTAMP type of data throw IllegalStateException

[GitBox <gi...@apache.org>]

jiasheng55 commented on a change in pull request #3135:
URL: https://github.com/apache/iceberg/pull/3135#discussion_r711542561



##########
File path: data/src/main/java/org/apache/iceberg/data/DeleteFilter.java
##########
@@ -134,9 +134,12 @@ protected long pos(T record) {
 
       Iterable<CloseableIterable<Record>> deleteRecords = Iterables.transform(deletes,
           delete -> openDeletes(delete, deleteSchema));
-      StructLikeSet deleteSet = Deletes.toEqualitySet(
-          // copy the delete records because they will be held in a set

Review comment:
       This comment is missing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org