[GitHub] [incubator-superset] rusackas commented on a change in pull request #10402: style: add fade transition to bottom border on navbar menu items

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #10402:
URL: https://github.com/apache/incubator-superset/pull/10402#discussion_r459203174



##########
File path: superset-frontend/src/components/Menu/Menu.jsx
##########
@@ -59,6 +59,28 @@ const StyledHeader = styled.header`
     flex-direction: column;
     justify-content: center;
   }
+
+  .navbar-nav > li > a {
+    &:after {
+      content: '';
+      position: absolute;
+      bottom: -3px;
+      left: 0;
+      width: 100%;
+      height: 3px;
+      background-color: #20a7c9;

Review comment:
       Actually, no need to import the `supersetTheme` as it's passed into all Emotion (👩‍🎤) components automagically. I'll add some code suggestions herein to illustrate the point.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org