You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/30 14:31:30 UTC
[GitHub] [pulsar] codelipenghui commented on a change in pull request #12132: [Broker] Fix prefix setting in JWT authn and avoid multi calls for the getProperty
codelipenghui commented on a change in pull request #12132:
URL: https://github.com/apache/pulsar/pull/12132#discussion_r719467355
##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java
##########
@@ -293,19 +293,19 @@ private SignatureAlgorithm getPublicKeyAlgType(ServiceConfiguration conf) throws
// get Token Audience Claim from configuration, if not configured return null.
private String getTokenAudienceClaim(ServiceConfiguration conf) throws IllegalArgumentException {
- if (conf.getProperty(confTokenAudienceClaimSettingName) != null
- && StringUtils.isNotBlank((String) conf.getProperty(confTokenAudienceClaimSettingName))) {
- return (String) conf.getProperty(confTokenAudienceClaimSettingName);
+ Object tokenAudienceClaim = conf.getProperty(confTokenAudienceClaimSettingName);
+ if (tokenAudienceClaim != null && StringUtils.isNotBlank((String) tokenAudienceClaim)) {
+ return (String) tokenAudienceClaim;
} else {
return null;
}
}
// get Token Audience that stands for this broker from configuration, if not configured return null.
private String getTokenAudience(ServiceConfiguration conf) throws IllegalArgumentException {
- if (conf.getProperty(confTokenAudienceSettingName) != null
- && StringUtils.isNotBlank((String) conf.getProperty(confTokenAudienceSettingName))) {
- return (String) conf.getProperty(confTokenAudienceSettingName);
+ Object tokenAudience = conf.getProperty(confTokenAudienceSettingName);
Review comment:
Same as the above comment
##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java
##########
@@ -293,19 +293,19 @@ private SignatureAlgorithm getPublicKeyAlgType(ServiceConfiguration conf) throws
// get Token Audience Claim from configuration, if not configured return null.
private String getTokenAudienceClaim(ServiceConfiguration conf) throws IllegalArgumentException {
- if (conf.getProperty(confTokenAudienceClaimSettingName) != null
- && StringUtils.isNotBlank((String) conf.getProperty(confTokenAudienceClaimSettingName))) {
- return (String) conf.getProperty(confTokenAudienceClaimSettingName);
+ Object tokenAudienceClaim = conf.getProperty(confTokenAudienceClaimSettingName);
+ if (tokenAudienceClaim != null && StringUtils.isNotBlank((String) tokenAudienceClaim)) {
+ return (String) tokenAudienceClaim;
Review comment:
```suggestion
String tokenAudienceClaim = (String) conf.getProperty(confTokenAudienceClaimSettingName);
if (tokenAudienceClaim != null && StringUtils.isNotBlank(tokenAudienceClaim)) {
return tokenAudienceClaim;
```
##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java
##########
@@ -293,19 +293,19 @@ private SignatureAlgorithm getPublicKeyAlgType(ServiceConfiguration conf) throws
// get Token Audience Claim from configuration, if not configured return null.
private String getTokenAudienceClaim(ServiceConfiguration conf) throws IllegalArgumentException {
- if (conf.getProperty(confTokenAudienceClaimSettingName) != null
- && StringUtils.isNotBlank((String) conf.getProperty(confTokenAudienceClaimSettingName))) {
- return (String) conf.getProperty(confTokenAudienceClaimSettingName);
+ Object tokenAudienceClaim = conf.getProperty(confTokenAudienceClaimSettingName);
+ if (tokenAudienceClaim != null && StringUtils.isNotBlank((String) tokenAudienceClaim)) {
+ return (String) tokenAudienceClaim;
Review comment:
We should avoid cast to String twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org