You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jclouds.apache.org by ga...@apache.org on 2015/03/31 05:44:15 UTC

[1/2] jclouds git commit: Upgrade to findbugs-maven-plugin 3.0.1

Repository: jclouds
Updated Branches:
  refs/heads/master df8407a1e -> 4f566d3b6


Upgrade to findbugs-maven-plugin 3.0.1

Release notes:

http://findbugs.sourceforge.net/Changes.html


Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/e5815525
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/e5815525
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/e5815525

Branch: refs/heads/master
Commit: e581552583196078283239c69a72ac27250989d0
Parents: df8407a
Author: Andrew Gaul <ga...@apache.org>
Authored: Mon Mar 30 19:58:29 2015 -0700
Committer: Andrew Gaul <ga...@apache.org>
Committed: Mon Mar 30 19:58:29 2015 -0700

----------------------------------------------------------------------
 project/pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/jclouds/blob/e5815525/project/pom.xml
----------------------------------------------------------------------
diff --git a/project/pom.xml b/project/pom.xml
index 6b03e50..94424d9 100644
--- a/project/pom.xml
+++ b/project/pom.xml
@@ -958,7 +958,7 @@
         <plugin>
           <groupId>org.codehaus.mojo</groupId>
           <artifactId>findbugs-maven-plugin</artifactId>
-          <version>3.0.0</version>
+          <version>3.0.1</version>
           <configuration>
             <omitVisitors>
               CheckRelaxingNullnessAnnotation,


[2/2] jclouds git commit: Address and suppress FindBugs warnings

Posted by ga...@apache.org.
Address and suppress FindBugs warnings


Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/4f566d3b
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/4f566d3b
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/4f566d3b

Branch: refs/heads/master
Commit: 4f566d3b6ea7859242885d9393b3fa8a651913b3
Parents: e581552
Author: Andrew Gaul <ga...@apache.org>
Authored: Mon Mar 30 20:20:14 2015 -0700
Committer: Andrew Gaul <ga...@apache.org>
Committed: Mon Mar 30 20:40:10 2015 -0700

----------------------------------------------------------------------
 .../elasticstack/compute/functions/ServerInfoToNodeMetadata.java   | 2 +-
 .../strategy/internal/FilesystemStorageStrategyImpl.java           | 1 -
 core/src/main/java/org/jclouds/io/payloads/ByteArrayPayload.java   | 1 -
 project/pom.xml                                                    | 1 +
 4 files changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/jclouds/blob/4f566d3b/apis/elasticstack/src/main/java/org/jclouds/elasticstack/compute/functions/ServerInfoToNodeMetadata.java
----------------------------------------------------------------------
diff --git a/apis/elasticstack/src/main/java/org/jclouds/elasticstack/compute/functions/ServerInfoToNodeMetadata.java b/apis/elasticstack/src/main/java/org/jclouds/elasticstack/compute/functions/ServerInfoToNodeMetadata.java
index 7b4f7d4..530dfc7 100644
--- a/apis/elasticstack/src/main/java/org/jclouds/elasticstack/compute/functions/ServerInfoToNodeMetadata.java
+++ b/apis/elasticstack/src/main/java/org/jclouds/elasticstack/compute/functions/ServerInfoToNodeMetadata.java
@@ -133,7 +133,7 @@ public class ServerInfoToNodeMetadata implements Function<ServerInfo, NodeMetada
          } catch (UncheckedExecutionException e) {
             logger.warn(e, "error finding drive %s: %s", input.getDriveUuid(), e.getMessage());
          }
-         return new VolumeBuilder().durable(true).type(Volume.Type.NAS).build();
+         return builder.durable(true).type(Volume.Type.NAS).build();
       }
    }
 

http://git-wip-us.apache.org/repos/asf/jclouds/blob/4f566d3b/apis/filesystem/src/main/java/org/jclouds/filesystem/strategy/internal/FilesystemStorageStrategyImpl.java
----------------------------------------------------------------------
diff --git a/apis/filesystem/src/main/java/org/jclouds/filesystem/strategy/internal/FilesystemStorageStrategyImpl.java b/apis/filesystem/src/main/java/org/jclouds/filesystem/strategy/internal/FilesystemStorageStrategyImpl.java
index 325b22c..a85c2b5 100644
--- a/apis/filesystem/src/main/java/org/jclouds/filesystem/strategy/internal/FilesystemStorageStrategyImpl.java
+++ b/apis/filesystem/src/main/java/org/jclouds/filesystem/strategy/internal/FilesystemStorageStrategyImpl.java
@@ -241,7 +241,6 @@ public class FilesystemStorageStrategyImpl implements LocalStorageStrategy {
       BlobBuilder builder = blobBuilders.get();
       builder.name(key);
       File file = getFileForBlobKey(container, key);
-      Path path = file.toPath();
       ByteSource byteSource;
 
       if (getDirectoryBlobSuffix(key) != null) {

http://git-wip-us.apache.org/repos/asf/jclouds/blob/4f566d3b/core/src/main/java/org/jclouds/io/payloads/ByteArrayPayload.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/jclouds/io/payloads/ByteArrayPayload.java b/core/src/main/java/org/jclouds/io/payloads/ByteArrayPayload.java
index 109fe71..dfaee12 100644
--- a/core/src/main/java/org/jclouds/io/payloads/ByteArrayPayload.java
+++ b/core/src/main/java/org/jclouds/io/payloads/ByteArrayPayload.java
@@ -31,7 +31,6 @@ public class ByteArrayPayload extends BasePayload<byte[]> {
       super(content);
       getContentMetadata().setContentLength(Long.valueOf(checkNotNull(content, "content").length));
       getContentMetadata().setContentMD5(md5);
-      checkArgument(content.length >= 0, "length cannot me negative");
    }
 
    /**

http://git-wip-us.apache.org/repos/asf/jclouds/blob/4f566d3b/project/pom.xml
----------------------------------------------------------------------
diff --git a/project/pom.xml b/project/pom.xml
index 94424d9..73108ea 100644
--- a/project/pom.xml
+++ b/project/pom.xml
@@ -967,6 +967,7 @@
               EqualsOperandShouldHaveClassCompatibleWithThis,
               FindBadCast2,
               FindHEmismatch,
+              FindMaskedFields,
               FindNullDeref,
               FindReturnRef,
               FindUnsatisfiedObligation,