You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/11/06 17:10:04 UTC
[GitHub] [ignite] akalash opened a new pull request #8435: IGNITE-13684 PageIoResolver added
akalash opened a new pull request #8435:
URL: https://github.com/apache/ignite/pull/8435
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] asfgit closed pull request #8435: IGNITE-13684 PageIoResolver added
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #8435:
URL: https://github.com/apache/ignite/pull/8435
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ibessonov commented on a change in pull request #8435: IGNITE-13684 PageIoResolver added
Posted by GitBox <gi...@apache.org>.
ibessonov commented on a change in pull request #8435:
URL: https://github.com/apache/ignite/pull/8435#discussion_r521166094
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/IgniteCacheOffheapManagerImpl.java
##########
@@ -1561,7 +1593,7 @@ void decrementSize(int cacheId) {
return grp.mvccEnabled() ? dataTree.isEmpty() : storageSize.get() == 0;
}
catch (IgniteCheckedException e) {
- U.error(log, "Failed to perform operation.", e);
+ U.error(grp.shared().logger(IgniteCacheOffheapManagerImpl.class), "Failed to perform operation.", e);
Review comment:
I don't know, I'll replace it with the filed access.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] akalash commented on a change in pull request #8435: IGNITE-13684 PageIoResolver added
Posted by GitBox <gi...@apache.org>.
akalash commented on a change in pull request #8435:
URL: https://github.com/apache/ignite/pull/8435#discussion_r520400185
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/IgniteCacheOffheapManagerImpl.java
##########
@@ -1561,7 +1593,7 @@ void decrementSize(int cacheId) {
return grp.mvccEnabled() ? dataTree.isEmpty() : storageSize.get() == 0;
}
catch (IgniteCheckedException e) {
- U.error(log, "Failed to perform operation.", e);
+ U.error(grp.shared().logger(IgniteCacheOffheapManagerImpl.class), "Failed to perform operation.", e);
Review comment:
Why don't you use log which was set in the constructor?
##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/database/inlinecolumn/ObjectHashInlineIndexColumn.java
##########
@@ -60,7 +63,8 @@ public ObjectHashInlineIndexColumn(Column col) {
/** {@inheritDoc} */
@Override protected Value get0(long pageAddr, int off) {
- return null;
+ int hashCode = PageUtils.getInt(pageAddr, off + 1);
+ return new ValueObjectHashCode(hashCode); //TODO Is this ok?
Review comment:
TODO should be removed
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/pagemem/PageMemoryImpl.java
##########
@@ -639,6 +640,7 @@ else if (throttlingPlc == ThrottlingPolicy.CHECKPOINT_BUFFER_ONLY)
* @return Data region configuration.
*/
private DataRegionConfiguration getDataRegionConfiguration() {
+ //TODO
Review comment:
TODO?
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/pagemem/PageMemoryImpl.java
##########
@@ -2479,6 +2479,7 @@ private long tryToFindSequentially(int cap, PageStoreWriter saveDirtyPage) throw
DataRegionConfiguration dataRegionCfg = getDataRegionConfiguration();
+ //TODO dataRegionCfg is null
Review comment:
TODO?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org