[GitHub] rabbah commented on a change in pull request #3467: Remove actionControllers tests from incubator-openwhisk repo

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #3467: Remove actionControllers tests from incubator-openwhisk repo
URL: https://github.com/apache/incubator-openwhisk/pull/3467#discussion_r193863012
 
 

 ##########
 File path: tests/src/test/scala/actionContainers/ActionContainer.scala
 ##########
 @@ -104,19 +113,25 @@ object ActionContainer {
       sys.props
         .get("docker.host")
         .orElse(sys.env.get("DOCKER_HOST"))
+        .orElse {
+          // Check if we are running on docker-machine env.
+          Option(WhiskProperties.getProperty("whisk.version.name")).filter(_.toLowerCase.contains("mac")).map {
+            case _ => s"tcp://${WhiskProperties.getMainDockerEndpoint}"
+          }
+        }
 
 Review comment:
   it's a nice convenience - the precedence order is -D, ENV, then whisk props.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services