[GitHub] [ignite-3] AMashenkov commented on a change in pull request #484: IGNITE-15107-2 Integrate DDL into Ignite 3.0

[GitBox <gi...@apache.org>]

AMashenkov commented on a change in pull request #484:
URL: https://github.com/apache/ignite-3/pull/484#discussion_r762062944



##########
File path: modules/api/src/main/java/org/apache/ignite/schema/definition/builder/PrimaryKeyDefinitionBuilder.java
##########
@@ -31,6 +32,14 @@
      */
     PrimaryKeyDefinitionBuilder withAffinityColumns(String... cols);
 
+    /**
+     * Sets affinity columns.
+     *
+     * @param cols Affinity columns. Must be a valid subset of ley columns.
+     * @return Primary index builder.
+     */
+    PrimaryKeyDefinitionBuilder withAffinityColumns(Set<String> cols);

Review comment:
       Does column order matter?
   Are we going to build an index on primary key implicitly ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org