You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by Daniel Shahaf <da...@elego.de> on 2012/04/26 06:51:14 UTC
Re: svn commit: r1330615 -
/subversion/trunk/subversion/include/private/svn_ra_private.h
gstein@apache.org wrote on Thu, Apr 26, 2012 at 01:00:15 -0000:
> Author: gstein
> Date: Thu Apr 26 01:00:15 2012
> New Revision: 1330615
>
> URL: http://svn.apache.org/viewvc?rev=1330615&view=rev
> Log:
> Add some documentation for the new stuff in svn_ra_private.
>
> * subversion/include/private/svn_ra_private.h:
> (svn_ra__provide_base_cb_t, svn_ra__provide_props_cb_t,
> svn_ra__get_copysrc_kind_cb_t, svn_ra__get_commit_ev2): update
> and expand docstrings
>
> Modified:
> subversion/trunk/subversion/include/private/svn_ra_private.h
>
> Modified: subversion/trunk/subversion/include/private/svn_ra_private.h
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/private/svn_ra_private.h?rev=1330615&r1=1330614&r2=1330615&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/include/private/svn_ra_private.h (original)
> +++ subversion/trunk/subversion/include/private/svn_ra_private.h Thu Apr 26 01:00:15 2012
> @@ -170,14 +182,53 @@ typedef svn_error_t *(*svn_ra__get_copys
> apr_pool_t *scratch_pool);
>
>
> -/* ### hand-wave... see svn_ra_get_commit_editor3() for the basics
> - ### of these parameters. */
> +/* Return an Ev2-based editor for performing commits.
> +
> + The editor is associated with the given SESSION, and its implied target
> + repository.
Is *EDITOR chrooted to the session's URL (in the "reparent" sense) and
its descendants?
> +*/
> svn_error_t *
> svn_ra__get_commit_ev2(svn_editor_t **editor,
> svn_ra_session_t *session,
> - apr_hash_t *revprop_table,
> - svn_commit_callback2_t callback,
> - void *callback_baton,
> + apr_hash_t *revprops,
> + svn_commit_callback2_t commit_cb,
> + void *commit_baton,
> apr_hash_t *lock_tokens,
> svn_boolean_t keep_locks,
> svn_ra__provide_base_cb_t provide_base_cb,
>
>
Re: svn commit: r1330615 - /subversion/trunk/subversion/include/private/svn_ra_private.h
Posted by Greg Stein <gs...@gmail.com>.
On Thu, Apr 26, 2012 at 00:51, Daniel Shahaf <da...@elego.de> wrote:
> gstein@apache.org wrote on Thu, Apr 26, 2012 at 01:00:15 -0000:
>> Author: gstein
>> Date: Thu Apr 26 01:00:15 2012
>> New Revision: 1330615
>>
>> URL: http://svn.apache.org/viewvc?rev=1330615&view=rev
>> Log:
>> Add some documentation for the new stuff in svn_ra_private.
>>
>> * subversion/include/private/svn_ra_private.h:
>> (svn_ra__provide_base_cb_t, svn_ra__provide_props_cb_t,
>> svn_ra__get_copysrc_kind_cb_t, svn_ra__get_commit_ev2): update
>> and expand docstrings
>>
>> Modified:
>> subversion/trunk/subversion/include/private/svn_ra_private.h
>>
>> Modified: subversion/trunk/subversion/include/private/svn_ra_private.h
>> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/private/svn_ra_private.h?rev=1330615&r1=1330614&r2=1330615&view=diff
>> ==============================================================================
>> --- subversion/trunk/subversion/include/private/svn_ra_private.h (original)
>> +++ subversion/trunk/subversion/include/private/svn_ra_private.h Thu Apr 26 01:00:15 2012
>> @@ -170,14 +182,53 @@ typedef svn_error_t *(*svn_ra__get_copys
>> apr_pool_t *scratch_pool);
>>
>>
>> -/* ### hand-wave... see svn_ra_get_commit_editor3() for the basics
>> - ### of these parameters. */
>> +/* Return an Ev2-based editor for performing commits.
>> +
>> + The editor is associated with the given SESSION, and its implied target
>> + repository.
>
> Is *EDITOR chrooted to the session's URL (in the "reparent" sense) and
> its descendants?
Ah. Good point. I had that in my head to document and forgot...
The commit editor is rooted at the repository root. All paths are
repos_relpath. IOW, no: not the session_relpath.
(the lock tokens are currently session_relpath though)
I'll update.
Thanks,
-g