You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by okram <gi...@git.apache.org> on 2017/04/13 16:57:22 UTC
[GitHub] tinkerpop pull request #601: TINKERPOP-1668: RepeatUnrollStrategy should not...
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/601
TINKERPOP-1668: RepeatUnrollStrategy should not execute if there is a LoopStep used.
https://issues.apache.org/jira/browse/TINKERPOP-1668
If the child traversal of `RepeatStep` has a `LoopsStep`, then `RepeatUnrollStrategy` should not be allowed as it the loops will have been linearized and thus, never incremented. Added test case to verify expected working behavior.
VOTE +1.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1668
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/601.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #601
----
commit e033e3c6f8132d0b461a75e479ceea8f8b4b9ca8
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2017-04-13T16:54:29Z
Fixed a bug in where should invalidate the strategy's application.
commit 710bcdba20b65ad33aa4af4b0792cabae9c9e1c8
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2017-04-13T16:56:54Z
got rid of unneeded imports.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #601: TINKERPOP-1668: RepeatUnrollStrategy should not execut...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/601
Cool.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #601: TINKERPOP-1668: RepeatUnrollStrategy should not execut...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/601
Very rare indeed. Maybe we should just add a tiny note (and/or an example) in the repeat steps docs.
```
g.V().repeat(out().sideEffect {println it.loops()}).iterate() // don't try this at home
g.withoutStrategies(RepeatUnrollStrategy).V().repeat(out().sideEffect {println it.loops()}).iterate() // cool
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #601: TINKERPOP-1668: RepeatUnrollStrategy should not...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/601
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #601: TINKERPOP-1668: RepeatUnrollStrategy should not execut...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/601
Lambda steps could do something with `it.loops()` and thus should have the same effect.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #601: TINKERPOP-1668: RepeatUnrollStrategy should not execut...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/601
Yes, and I decided not to include that given that its rare and the only way to test would be to look for a `LambdaHolder` which would then make the strategy not apply to lots of other situations. I can add that break out of if you think its worth it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #601: TINKERPOP-1668: RepeatUnrollStrategy should not execut...
Posted by twilmes <gi...@git.apache.org>.
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/601
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---