[GitHub] [pinot] xiangfu0 commented on pull request #11528: fixing dateTimeConvert with double scientific notation values

["xiangfu0 (via GitHub)" <gi...@apache.org>]

xiangfu0 commented on PR #11528:
URL: https://github.com/apache/pinot/pull/11528#issuecomment-1708820602

   > I initially thought that we should block "double + epoch" combination but I realized that we probably need to do this because `max()` always convert the output into double.
   > 
   > Shouldn't we preserve the type when max/min aggregation function is processed? (I'm not sure about the min/max convention for SQL though).
   > 
   > If we preserve the type from max/min aggregation function, we can even block the double type for this function as the epoch is int/long and simple date is in string.
   > 
   > This PR looks good to me as it will unblock the issue that you posted in the example.
   
   Yes, this is done by v2 but not v1, same query will actually work in v2 engine as the return type of max(long) is long.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org