You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/12 23:49:52 UTC

[GitHub] [pulsar] bharanic-dev commented on a change in pull request #10201: [PIP-82] [pulsar-broker] incorporate review feedback

bharanic-dev commented on a change in pull request #10201:
URL: https://github.com/apache/pulsar/pull/10201#discussion_r612024612



##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -687,12 +687,6 @@
     )
     private String resourceUsageTransportClassName = "";
 
-    @FieldContext(

Review comment:
       @jerrypeng while reviewing the previous PR(https://github.com/apache/pulsar/pull/10008), @codelipenghui and @315157973 gave feedback that the topic name is internal implementation detail that the user doesn't need to be exposed to. I did not have a strong reason to go the other way, so made this change. We can always make it configurable in the future, if we find that there is a use-case for it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org