You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2016/11/05 22:03:30 UTC
svn commit: r1768283 - in /tomcat/trunk/java/org/apache/catalina: Realm.java
realm/DataSourceRealm.java
Author: markt
Date: Sat Nov 5 22:03:30 2016
New Revision: 1768283
URL: http://svn.apache.org/viewvc?rev=1768283&view=rev
Log:
Keep checkstyle happy
Modified:
tomcat/trunk/java/org/apache/catalina/Realm.java
tomcat/trunk/java/org/apache/catalina/realm/DataSourceRealm.java
Modified: tomcat/trunk/java/org/apache/catalina/Realm.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/Realm.java?rev=1768283&r1=1768282&r2=1768283&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/Realm.java (original)
+++ tomcat/trunk/java/org/apache/catalina/Realm.java Sat Nov 5 22:03:30 2016
@@ -237,7 +237,7 @@ public interface Realm {
* Return the availability of the realm for authentication.
* @return <code>true</code> if the realm is able to perform authentication
*/
- default public boolean isAvailable() {
+ public default boolean isAvailable() {
return true;
}
}
Modified: tomcat/trunk/java/org/apache/catalina/realm/DataSourceRealm.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/realm/DataSourceRealm.java?rev=1768283&r1=1768282&r2=1768283&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/realm/DataSourceRealm.java (original)
+++ tomcat/trunk/java/org/apache/catalina/realm/DataSourceRealm.java Sat Nov 5 22:03:30 2016
@@ -393,7 +393,7 @@ public class DataSourceRealm extends Rea
connectionSuccess = true;
return connection;
} catch (Exception e) {
- connectionSuccess = false;
+ connectionSuccess = false;
// Log the problem for posterity
containerLog.error(sm.getString("dataSourceRealm.exception"), e);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1768283 - in /tomcat/trunk/java/org/apache/catalina:
Realm.java realm/DataSourceRealm.java
Posted by Mark Thomas <ma...@apache.org>.
On 06/11/2016 08:24, R�my Maucherat wrote:
> 2016-11-05 23:03 GMT+01:00 <ma...@apache.org>:
>
>> Author: markt
>> Date: Sat Nov 5 22:03:30 2016
>> New Revision: 1768283
>>
>> URL: http://svn.apache.org/viewvc?rev=1768283&view=rev
>> Log:
>> Keep checkstyle happy
>>
>
> Thanks, unfortunately I had disabled checkstyle at some point to do other
> things.
No problem. I'm sure you've done the same for me in the past.
Mark
>
> R�my
>
>>
>> Modified:
>> tomcat/trunk/java/org/apache/catalina/Realm.java
>> tomcat/trunk/java/org/apache/catalina/realm/DataSourceRealm.java
>>
>> Modified: tomcat/trunk/java/org/apache/catalina/Realm.java
>> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/
>> catalina/Realm.java?rev=1768283&r1=1768282&r2=1768283&view=diff
>> ============================================================
>> ==================
>> --- tomcat/trunk/java/org/apache/catalina/Realm.java (original)
>> +++ tomcat/trunk/java/org/apache/catalina/Realm.java Sat Nov 5 22:03:30
>> 2016
>> @@ -237,7 +237,7 @@ public interface Realm {
>> * Return the availability of the realm for authentication.
>> * @return <code>true</code> if the realm is able to perform
>> authentication
>> */
>> - default public boolean isAvailable() {
>> + public default boolean isAvailable() {
>> return true;
>> }
>> }
>>
>> Modified: tomcat/trunk/java/org/apache/catalina/realm/DataSourceRealm.java
>> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/
>> catalina/realm/DataSourceRealm.java?rev=1768283&r1=1768282&r2=1768283&
>> view=diff
>> ============================================================
>> ==================
>> --- tomcat/trunk/java/org/apache/catalina/realm/DataSourceRealm.java
>> (original)
>> +++ tomcat/trunk/java/org/apache/catalina/realm/DataSourceRealm.java Sat
>> Nov 5 22:03:30 2016
>> @@ -393,7 +393,7 @@ public class DataSourceRealm extends Rea
>> connectionSuccess = true;
>> return connection;
>> } catch (Exception e) {
>> - connectionSuccess = false;
>> + connectionSuccess = false;
>> // Log the problem for posterity
>> containerLog.error(sm.getString("dataSourceRealm.exception"),
>> e);
>> }
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1768283 - in /tomcat/trunk/java/org/apache/catalina:
Realm.java realm/DataSourceRealm.java
Posted by Rémy Maucherat <re...@apache.org>.
2016-11-05 23:03 GMT+01:00 <ma...@apache.org>:
> Author: markt
> Date: Sat Nov 5 22:03:30 2016
> New Revision: 1768283
>
> URL: http://svn.apache.org/viewvc?rev=1768283&view=rev
> Log:
> Keep checkstyle happy
>
Thanks, unfortunately I had disabled checkstyle at some point to do other
things.
Rémy
>
> Modified:
> tomcat/trunk/java/org/apache/catalina/Realm.java
> tomcat/trunk/java/org/apache/catalina/realm/DataSourceRealm.java
>
> Modified: tomcat/trunk/java/org/apache/catalina/Realm.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/
> catalina/Realm.java?rev=1768283&r1=1768282&r2=1768283&view=diff
> ============================================================
> ==================
> --- tomcat/trunk/java/org/apache/catalina/Realm.java (original)
> +++ tomcat/trunk/java/org/apache/catalina/Realm.java Sat Nov 5 22:03:30
> 2016
> @@ -237,7 +237,7 @@ public interface Realm {
> * Return the availability of the realm for authentication.
> * @return <code>true</code> if the realm is able to perform
> authentication
> */
> - default public boolean isAvailable() {
> + public default boolean isAvailable() {
> return true;
> }
> }
>
> Modified: tomcat/trunk/java/org/apache/catalina/realm/DataSourceRealm.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/
> catalina/realm/DataSourceRealm.java?rev=1768283&r1=1768282&r2=1768283&
> view=diff
> ============================================================
> ==================
> --- tomcat/trunk/java/org/apache/catalina/realm/DataSourceRealm.java
> (original)
> +++ tomcat/trunk/java/org/apache/catalina/realm/DataSourceRealm.java Sat
> Nov 5 22:03:30 2016
> @@ -393,7 +393,7 @@ public class DataSourceRealm extends Rea
> connectionSuccess = true;
> return connection;
> } catch (Exception e) {
> - connectionSuccess = false;
> + connectionSuccess = false;
> // Log the problem for posterity
> containerLog.error(sm.getString("dataSourceRealm.exception"),
> e);
> }
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>