[GitHub] [tvm] ashutosh-arm commented on a diff in pull request #15667: [microTVM] Check the output of microNPU demos in CI

["ashutosh-arm (via GitHub)" <gi...@apache.org>]

ashutosh-arm commented on code in PR #15667:
URL: https://github.com/apache/tvm/pull/15667#discussion_r1316163715


##########
tests/scripts/task_demo_microtvm.sh:
##########
@@ -20,6 +20,12 @@ set -euxo pipefail
 
 source tests/scripts/setup-pytest-env.sh
 
+cleanup()
+{
+    rm -f out.log
+}
+trap cleanup 0
+
 pushd apps/microtvm/cmsisnn
  timeout 5m ./run_demo.sh

Review Comment:
   Can the same check be added here?



##########
tests/scripts/task_demo_microtvm.sh:
##########
@@ -34,6 +40,18 @@ FVP_PATH="/opt/arm/FVP_Corstone_SSE-300_Ethos-U55"
 CMAKE_PATH="/opt/arm/cmake/bin/cmake"
 FREERTOS_PATH="/opt/freertos/FreeRTOSv202112.00"
 
- timeout 5m ./run_demo.sh --fvp_path $FVP_PATH --cmake_path $CMAKE_PATH
- timeout 5m ./run_demo.sh --fvp_path $FVP_PATH --cmake_path $CMAKE_PATH --freertos_path $FREERTOS_PATH
+timeout 5m ./run_demo.sh --fvp_path $FVP_PATH --cmake_path $CMAKE_PATH > out.log

Review Comment:
   Should redirection be done to a tmp file? Also, a clean up of the log should be useful.
   Example: https://github.com/apache/tvm/blob/476d9d1d41980ad35cd6a4d044c17fea2210f352/tests/scripts/task_python_docs.sh#L53



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org