[GitHub] [arrow] kou commented on a diff in pull request #35277: GH-35274: [Java][CI] Enable GCS on MacOS

["kou (via GitHub)" <gi...@apache.org>]

kou commented on code in PR #35277:
URL: https://github.com/apache/arrow/pull/35277#discussion_r1218624951


##########
ci/scripts/java_jni_macos_build.sh:
##########
@@ -75,15 +77,18 @@ cmake \
   -DARROW_DEPENDENCY_USE_SHARED=OFF \
   -DARROW_GANDIVA=${ARROW_GANDIVA} \
   -DARROW_GANDIVA_STATIC_LIBSTDCPP=ON \
+  -DARROW_GCS=${ARROW_GCS} \
   -DARROW_ORC=${ARROW_ORC} \
   -DARROW_PARQUET=${ARROW_PARQUET} \
   -DARROW_S3=${ARROW_S3} \
   -DARROW_USE_CCACHE=${ARROW_USE_CCACHE} \
+  -DARROW_WITH_SNAPPY=ON \

Review Comment:
   If `ARROW_WITH_SNAPPY` is required for `ARROW_GCS`, could you enable `ARROW_WITH_SNAPPY` automatically with `ARROW_GCS`?
   
   ```diff
   diff --git a/cpp/cmake_modules/DefineOptions.cmake b/cpp/cmake_modules/DefineOptions.cmake
   index e2ad9e7a8..247a190ae 100644
   --- a/cpp/cmake_modules/DefineOptions.cmake
   +++ b/cpp/cmake_modules/DefineOptions.cmake
   @@ -335,7 +335,10 @@ takes precedence over ccache if a storage backend is configured" ON)
                    ARROW_WITH_UTF8PROC)
    
      define_option(ARROW_GCS
   -                "Build Arrow with GCS support (requires the GCloud SDK for C++)" OFF)
   +                "Build Arrow with GCS support (requires the GCloud SDK for C++)"
   +                OFF
   +                DEPENDS
   +                ARROW_WITH_SNAPPY)
    
      define_option(ARROW_HDFS "Build the Arrow HDFS bridge" OFF)
    ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org