[GitHub] [incubator-superset] semantiDan opened a new pull request #8003: Added better display of NULL values in FilterableTable (as in SQL Lab Results)

[GitBox <gi...@apache.org>]

semantiDan opened a new pull request #8003: Added better display of NULL values in FilterableTable (as in SQL Lab Results)
URL: https://github.com/apache/incubator-superset/pull/8003
 
 
   ###  Enhancement (new features, refinement)
   
   Choose one
   
   - [ ] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   
   While working with a large, non-curated and diverse database consisting of many columns and rows per table I found myself **painfully** trying to distinguish null values from actual strings/numbers.
   
   Whatsmore, by sorting columns that were supposed to be numerical, the **null values sometimes took precedence over the order** when I was trying to sort said columns.
   
   - If the value of a cell is null, it shows as NULL (italic and light gray) to easily distinguish it from other values in the results table.
   - When sorting a column with NULL values, NULL values always come last regardless of the sorting order.
   
   More information can be found in Issue #7983 (Better Visualization and Sorting for NULL values)
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   **Before change** when sorting by ascending order for **totaltracks** column:
   ![before-totaltracks-asc](https://user-images.githubusercontent.com/41392410/62629149-4d222780-b935-11e9-9463-6a110c2e89d3.png)
   
   **Before change** when sorting by descending order for **totaltracks** column:
   ![before-totaltracks-desc](https://user-images.githubusercontent.com/41392410/62629177-5ad7ad00-b935-11e9-91fb-90cddbbdd0bd.png)
   
   
   **After change** when sorting by ascending order for **totaltracks** column:
   ![after-totaltracks-asc](https://user-images.githubusercontent.com/41392410/62629204-675c0580-b935-11e9-9ec6-6a982275c9ec.png)
   
   **After change** when sorting by descending order for **totaltracks** column:
   ![after-totaltracks-desc](https://user-images.githubusercontent.com/41392410/62629251-8064b680-b935-11e9-8611-c81847fe142b.png)
   
   ### TEST PLAN
   Run any query in SQL lab in which the results contain NULL values and sort the column.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org