You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/07/30 20:54:33 UTC
Review Request 13076: Added help for the /master/redirect endpoint.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13076/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Repository: mesos-git
Description
-------
See above.
Diffs
-----
src/master/http.cpp a114462e15bc61da3178dba6bf40d32b4b7b55fa
src/master/master.hpp bdaf4d64c0ecdaf4539b9d13b2e3751f5731c0aa
src/master/master.cpp e4507acd97ebaf2ce693ec7343e9a4a563f6ff80
Diff: https://reviews.apache.org/r/13076/diff/
Testing
-------
make check + browser /help navigation
Thanks,
Ben Mahler
Re: Review Request 13076: Added help for the /master/redirect endpoint.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13076/#review24266
-----------------------------------------------------------
Ship it!
src/master/http.cpp
<https://reviews.apache.org/r/13076/#comment48089>
You might want to include another note explaining that this is broken right now "on the cloud" since we'll attempt to redirect you to a private IP address.
- Benjamin Hindman
On July 30, 2013, 6:54 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13076/
> -----------------------------------------------------------
>
> (Updated July 30, 2013, 6:54 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See above.
>
>
> Diffs
> -----
>
> src/master/http.cpp a114462e15bc61da3178dba6bf40d32b4b7b55fa
> src/master/master.hpp bdaf4d64c0ecdaf4539b9d13b2e3751f5731c0aa
> src/master/master.cpp e4507acd97ebaf2ce693ec7343e9a4a563f6ff80
>
> Diff: https://reviews.apache.org/r/13076/diff/
>
>
> Testing
> -------
>
> make check + browser /help navigation
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 13076: Added help for the /master/redirect endpoint.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13076/#review24261
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On July 30, 2013, 6:54 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13076/
> -----------------------------------------------------------
>
> (Updated July 30, 2013, 6:54 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See above.
>
>
> Diffs
> -----
>
> src/master/http.cpp a114462e15bc61da3178dba6bf40d32b4b7b55fa
> src/master/master.hpp bdaf4d64c0ecdaf4539b9d13b2e3751f5731c0aa
> src/master/master.cpp e4507acd97ebaf2ce693ec7343e9a4a563f6ff80
>
> Diff: https://reviews.apache.org/r/13076/diff/
>
>
> Testing
> -------
>
> make check + browser /help navigation
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 13076: Added help for the /master/redirect endpoint.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13076/
-----------------------------------------------------------
(Updated July 31, 2013, 1:36 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Added a note about /redirect being broken on cloud environments as it will attempt to redirect to the private IP address. (per benh review)
Repository: mesos-git
Description
-------
See above.
Diffs (updated)
-----
src/master/http.cpp a114462e15bc61da3178dba6bf40d32b4b7b55fa
src/master/master.hpp bdaf4d64c0ecdaf4539b9d13b2e3751f5731c0aa
src/master/master.cpp e4507acd97ebaf2ce693ec7343e9a4a563f6ff80
Diff: https://reviews.apache.org/r/13076/diff/
Testing
-------
make check + browser /help navigation
Thanks,
Ben Mahler