You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/10/06 20:49:36 UTC

[GitHub] [trafficserver] bneradt edited a comment on issue #7242: Logging continuously tries to delete logs

bneradt edited a comment on issue #7242:
URL: https://github.com/apache/trafficserver/issues/7242#issuecomment-704533270


   This actually isn't due to the unique_ptrs or these objects being created on the heap. This is due to sort being called for each candidate (1000 files in the Doc tests case):
   https://github.com/apache/trafficserver/blob/c23c5a4be0ebf000ed924819633b11ce036f928e/proxy/logging/RolledLogDeleter.cc#L90
   
   That should only be called once if we decide to remove candidates. I'll get a PR up shortly.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org