[GitHub] [tez] abstractdog commented on pull request #228: TEZ-4430: Fix tez.task.launch.cmd-opts property not working

[GitBox <gi...@apache.org>]

abstractdog commented on PR #228:
URL: https://github.com/apache/tez/pull/228#issuecomment-1173175660

   thanks @ganeshashree for reporting this one
   I think as we're touching this part, we should delete the below method (which has no value, callers can use addLog4jSystemProperties directly, just addLog4jSystemProperties needs to have the null check):
   ```
     static void maybeAddDefaultLoggingJavaOpts(String logLevel, List<String> vargs) {
       Objects.requireNonNull(vargs);
       TezClientUtils.addLog4jSystemProperties(logLevel, vargs);
     }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org