You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/12/28 13:14:49 UTC

[GitHub] [skywalking-cli] wu-sheng commented on a change in pull request #26: Make use of server timezone API when possible

wu-sheng commented on a change in pull request #26: Make use of server timezone API when possible
URL: https://github.com/apache/skywalking-cli/pull/26#discussion_r361793327
 
 

 ##########
 File path: commands/interceptor/duration.go
 ##########
 @@ -66,11 +68,20 @@ func DurationInterceptor(ctx *cli.Context) error {
 // NOTE that when either(both) `start` or `end` is(are) given, there is no timezone info
 // in the format, (e.g. 2019-11-09 1001), so they'll be considered as UTC-based,
 
 Review comment:
   The comments need to change based on the new logic.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services