[GitHub] [pulsar] jiazhai commented on pull request #10616: MessageCrypto interface should not expose Netty ByteBuf class in the API

[GitBox <gi...@apache.org>]

jiazhai commented on pull request #10616:
URL: https://github.com/apache/pulsar/pull/10616#issuecomment-842896878


   > Overall LGTM
   > 
   > but the build failed
   > the build failed:
   > 
   > ```
   > Error:  COMPILATION ERROR : 
   > Error:  /home/runner/work/pulsar/pulsar/pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java:[3090,42] method decrypt in interface org.apache.pulsar.client.api.MessageCrypto<MetadataT,BuilderT> cannot be applied to given types;
   >   required: java.util.function.Supplier,java.nio.ByteBuffer,java.nio.ByteBuffer,org.apache.pulsar.client.api.CryptoKeyReader
   >   found: ()->messageMetadata,io.netty.buffer.ByteBuf,org.apache.pulsar.client.api.CryptoKeyReader
   >   reason: actual and formal argument lists differ in length
   > Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile (default-testCompile) on project pulsar-broker: Compilation failure
   > Error:  /home/runner/work/pulsar/pulsar/pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java:[3090,42] method decrypt in interface org.apache.pulsar.client.api.MessageCrypto<MetadataT,BuilderT> cannot be applied to given types;
   > Error:    required: java.util.function.Supplier,java.nio.ByteBuffer,java.nio.ByteBuffer,org.apache.pulsar.client.api.CryptoKeyReader
   > Error:    found: ()->messageMetadata,io.netty.buffer.ByteBuf,org.apache.pulsar.client.api.CryptoKeyReader
   > Error:    reason: actual and formal argument lists differ in length
   > Error:  -> [Help 1]
   > Error:  
   > Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
   > ```
   
   looks like we need care some implementation in the tests. but this change will make the management easier. +1.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org