[GitHub] [superset] zhaoyongjie commented on a diff in pull request #19761: fix(plugin-chart-echarts): [feature-parity] apply button of annotation layer doesn't work as expected

[GitBox <gi...@apache.org>]

zhaoyongjie commented on code in PR #19761:
URL: https://github.com/apache/superset/pull/19761#discussion_r892079529


##########
superset-frontend/packages/superset-ui-chart-controls/src/sections/annotationsAndLayers.tsx:
##########
@@ -33,6 +34,7 @@ export const annotationsAndLayersControls: ControlPanelSectionConfig = {
           label: '',
           default: annotationLayers,
           description: t('Annotation Layers'),
+          renderTrigger: true,

Review Comment:
   @stephenLYZ  the `renderTrigger == ture` means that client rerenders and doesn't send a query, but here is an exception. add a comment here. Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org