You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/13 04:01:48 UTC

[GitHub] [apisix] bfcx opened a new issue #4037: [discuss]: keep backward compatibility of apisix admin api or manager api

bfcx opened a new issue #4037:
URL: https://github.com/apache/apisix/issues/4037


   When upgrading APISIX form v1.5 to v2.4, I find that the response body of admin api in APISIX2.4 are not keep compatibility with that in v1.5.
   
   In APISIX 1.5, config restored by etcd v2,  response body returned by admin api both contains the field:
   "modifiedIndex("mod_revision" in etcd v3)" and "prevNode("prev_kv" in etcd v3)".
   
   BUT, in APISIX 2.4, response body of admin api and manager api are not contains these fields.
   
   We've developed series of apis base on APISIX1.5 admin api which can perform batch operations of CURDs for apisix config, so, in our apis we used field "modifiedIndex" and "prevNode" for atomicity guarantee and failed rollback.
   
   **DISCUSS**:
   Wish to add these fields in response body of admin api and manager api in APISIX2.4, to keep compatibility with that in v1.5.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #4037: [discuss]: keep backward compatibility of apisix admin api or manager api

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #4037:
URL: https://github.com/apache/apisix/issues/4037#issuecomment-818544126


   Those fields are removed intentionally because we have plan to support non-etcd storage.
   
   @bfcx 
   Will you contribute the batch operation support to us so we can maintain the backward compatibility?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] gxthrj commented on issue #4037: [discuss]: keep backward compatibility of apisix admin api or manager api

Posted by GitBox <gi...@apache.org>.
gxthrj commented on issue #4037:
URL: https://github.com/apache/apisix/issues/4037#issuecomment-818533037


   cc @nic-chen @spacewander 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] nic-chen commented on issue #4037: [discuss]: keep backward compatibility of apisix admin api or manager api

Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #4037:
URL: https://github.com/apache/apisix/issues/4037#issuecomment-819219259


   > Those fields are removed intentionally because we have plan to support non-etcd storage.
   
   Yes, so we only return generic values, not the data unique to etcd.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #4037: [discuss]: keep backward compatibility of apisix admin api or manager api

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #4037:
URL: https://github.com/apache/apisix/issues/4037#issuecomment-846982301


   Closed as lack of response.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander closed issue #4037: [discuss]: keep backward compatibility of apisix admin api or manager api

Posted by GitBox <gi...@apache.org>.
spacewander closed issue #4037:
URL: https://github.com/apache/apisix/issues/4037


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org