You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/20 13:20:10 UTC

[GitHub] [beam] bullet03 opened a new pull request, #21949: [WEBSITE] fix relative paths bug on staging in js files

bullet03 opened a new pull request, #21949:
URL: https://github.com/apache/beam/pull/21949

   - add relURL to page-nav.js and copy-to-clipboard.js
   - add `resources.ExecuteAsTemplate` to head.html
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AKosolapov commented on pull request #21949: [WEBSITE] fix relative paths bug on staging in js files

Posted by GitBox <gi...@apache.org>.
AKosolapov commented on PR #21949:
URL: https://github.com/apache/beam/pull/21949#issuecomment-1179254209

   @pabloem Could you please help with reviewing and merging this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] alevtinaboiko commented on pull request #21949: [WEBSITE] fix relative paths bug on staging in js files

Posted by GitBox <gi...@apache.org>.
alevtinaboiko commented on PR #21949:
URL: https://github.com/apache/beam/pull/21949#issuecomment-1178877586

   Verified, works as expected. Reviewed and tested by QA


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] aromanenko-dev merged pull request #21949: [WEBSITE] fix relative paths bug on staging in js files

Posted by GitBox <gi...@apache.org>.
aromanenko-dev merged PR #21949:
URL: https://github.com/apache/beam/pull/21949


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #21949: [WEBSITE] fix relative paths bug on staging in js files

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21949:
URL: https://github.com/apache/beam/pull/21949#issuecomment-1160441492

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on pull request #21949: [WEBSITE] fix relative paths bug on staging in js files

Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #21949:
URL: https://github.com/apache/beam/pull/21949#issuecomment-1177752865

   before:
   ![staging_bug](https://user-images.githubusercontent.com/61748758/177805811-21c6184a-255b-46dd-b7cd-1d3699acf718.gif)
   
   after:
   ![staging_fixed](https://user-images.githubusercontent.com/61748758/177805866-c672b1fe-2da7-4a0e-a0d6-eeded35b3757.gif)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on pull request #21949: [WEBSITE] fix relative paths bug on staging in js files

Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #21949:
URL: https://github.com/apache/beam/pull/21949#issuecomment-1179242272

   R: @pcoet 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #21949: [WEBSITE] fix relative paths bug on staging in js files

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21949:
URL: https://github.com/apache/beam/pull/21949#issuecomment-1160441494

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #21949: [WEBSITE] fix relative paths bug on staging in js files

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21949:
URL: https://github.com/apache/beam/pull/21949#issuecomment-1160441497

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on pull request #21949: [WEBSITE] fix relative paths bug on staging in js files

Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #21949:
URL: https://github.com/apache/beam/pull/21949#issuecomment-1195098419

   @aromanenko-dev, current PR was approved. Could you, please, help with merging?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on pull request #21949: [WEBSITE] fix relative paths bug on staging in js files

Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #21949:
URL: https://github.com/apache/beam/pull/21949#issuecomment-1179242762

   R: @pcoet


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on pull request #21949: [WEBSITE] fix relative paths bug on staging in js files

Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #21949:
URL: https://github.com/apache/beam/pull/21949#issuecomment-1195702397

   > Thanks, merged
   
   Thank you for the help!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] aromanenko-dev commented on pull request #21949: [WEBSITE] fix relative paths bug on staging in js files

Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on PR #21949:
URL: https://github.com/apache/beam/pull/21949#issuecomment-1195286473

   Thanks, merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on pull request #21949: [WEBSITE] fix relative paths bug on staging in js files

Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #21949:
URL: https://github.com/apache/beam/pull/21949#issuecomment-1179247780

   @pcoet, PR is ready. Could you review it, please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #21949: [WEBSITE] fix relative paths bug on staging in js files

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21949:
URL: https://github.com/apache/beam/pull/21949#issuecomment-1160441491

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #21949: [WEBSITE] fix relative paths bug on staging in js files

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21949:
URL: https://github.com/apache/beam/pull/21949#issuecomment-1160441489

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org