You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "zhangfei9734 (GitHub)" <gi...@apache.org> on 2019/03/26 05:43:08 UTC
[GitHub] [incubator-dubbo] zhangfei9734 opened pull request #3734:
fix #3727
## What is the purpose of the change
Fixed the problem that the protocoluff protocol is not judged empty when serialized
## Brief changelog
XXXXX
## Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3734 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] CrazyHZM closed pull request #3734:
[Dubbo-3727] Fix NullPointerException when protocoluff protocol serializes an
empty object
Posted by "CrazyHZM (GitHub)" <gi...@apache.org>.
[ pull request closed by CrazyHZM ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3734 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] CrazyHZM commented on issue #3734:
[Dubbo-3727] Fix NullPointerException when protocoluff protocol serializes an
empty object
Posted by "CrazyHZM (GitHub)" <gi...@apache.org>.
> @CrazyHZM Will this merge request be released in 2.7.1-RELEASE?
This merge request will be released in 2.7.2.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3734 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] zhangfei9734 commented on issue #3734:
[Dubbo-3727] Fix NullPointerException when protocoluff protocol serializes an
empty object
Posted by "zhangfei9734 (GitHub)" <gi...@apache.org>.
@CrazyHZM Will this merge request be released in 2.7.1-RELEASE?
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3734 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #3734:
[Dubbo-3727] Fix NullPointerException when protocoluff protocol serializes an
empty object
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3734?src=pr&el=h1) Report
> Merging [#3734](https://codecov.io/gh/apache/incubator-dubbo/pull/3734?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/ad72159b0e3ff641e3a08754297c81278b94d94e?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/3734?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3734 +/- ##
===========================================
+ Coverage 63.58% 63.6% +0.01%
Complexity 71 71
===========================================
Files 703 703
Lines 31000 31000
Branches 5022 5022
===========================================
+ Hits 19712 19716 +4
- Misses 9018 9020 +2
+ Partials 2270 2264 -6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3734?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/serialize/protostuff/ProtostuffObjectOutput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3734/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLXByb3Rvc3R1ZmYvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbW1vbi9zZXJpYWxpemUvcHJvdG9zdHVmZi9Qcm90b3N0dWZmT2JqZWN0T3V0cHV0LmphdmE=) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3734/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==) | `79.52% <0%> (-1.19%)` | `0% <0%> (ø)` | |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3734/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `74.14% <0%> (+1.36%)` | `0% <0%> (ø)` | :arrow_down: |
| [...bo/rpc/cluster/support/FailbackClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3734/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsYmFja0NsdXN0ZXJJbnZva2VyLmphdmE=) | `70.49% <0%> (+3.27%)` | `0% <0%> (ø)` | :arrow_down: |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3734/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `67.39% <0%> (+4.34%)` | `0% <0%> (ø)` | :arrow_down: |
| [...ng/exchange/support/header/HeartbeatTimerTask.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3734/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFydGJlYXRUaW1lclRhc2suamF2YQ==) | `78.94% <0%> (+5.26%)` | `0% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3734?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3734?src=pr&el=footer). Last update [ad72159...3b97be1](https://codecov.io/gh/apache/incubator-dubbo/pull/3734?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3734 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] CrazyHZM commented on issue #3734:
[Dubbo-3727] Fix NullPointerException when protocoluff protocol serializes an
empty object
Posted by "CrazyHZM (GitHub)" <gi...@apache.org>.
LGTM
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3734 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] kexianjun commented on pull request #3734:
fix #3727
Posted by "kexianjun (GitHub)" <gi...@apache.org>.
a license header is needed here
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3734 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] CrazyHZM commented on pull request #3734:
fix #3727
Posted by "CrazyHZM (GitHub)" <gi...@apache.org>.
Dubbo has a dubbo-serialization-test module that can be added to the module.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3734 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org