You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datasketches.apache.org by "blacelle (via GitHub)" <gi...@apache.org> on 2026/04/01 20:40:17 UTC

[I] Add proper module name in Manifest (datasketches-java)

blacelle opened a new issue, #731:
URL: https://github.com/apache/datasketches-java/issues/731

   Hello,
   
   Any plan to add proper jpms/JDK9 module configuration into the library?
   
   Current manifest looks like :
   ```
   Manifest-Version: 1.0
   Build-Jdk-Spec: 25
   Build-OS: Mac OS X aarch64 26.1
   Build-Tool-Jdk-Spec: 25
   GroupId-ArtifactId: org.apache.datasketches:datasketches-java
   Implementation-Vendor: The Apache Software Foundation
   git-branch: 9.0.X
   git-commit-id: f3b334b380feee9f928500de9adb6bbf763fc104
   git-commit-tag: 9.0.0-RC1
   git-commit-time: 
   git-commit-user-email: leerho@gmail.com
   ```
   
   An easy way forward would be through an additional `Automatic-Module-Name` entry, like:
   ```
   Automatic-Module-Name: org.apache.datasketches
   ```
   
   it can be done with something like:
   ```
   <plugin>
   	<groupId>org.apache.maven.plugins</groupId>
   	<artifactId>maven-jar-plugin</artifactId>
   	<configuration>
   		<archive>
   			<manifestEntries>
   				<Automatic-Module-Name>org.apache.datasketches</Automatic-Module-Name>
   			</manifestEntries>
   		</archive>
   	</configuration>
   </plugin>
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org


Re: [I] Add proper module name in Manifest (datasketches-java)

Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho commented on issue #731:
URL: https://github.com/apache/datasketches-java/issues/731#issuecomment-4173549311

   I'm open to this, but how does this help you exactly?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org


Re: [I] Add proper module name in Manifest (datasketches-java)

Posted by "blacelle (via GitHub)" <gi...@apache.org>.
blacelle commented on issue #731:
URL: https://github.com/apache/datasketches-java/issues/731#issuecomment-4324905684

   Any news @leerho ? TY


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org


Re: [I] Add proper module name in Manifest (datasketches-java)

Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho commented on issue #731:
URL: https://github.com/apache/datasketches-java/issues/731#issuecomment-4597385690

   I have Automatic Module Name configured for the next version of datasketches-memory-7.0.0, which should be released in the next few weeks.  Once this is out, I can start work on upgrading datasketches-java versions 7.X (for Java 17) and 8.X (for Java 21) to use the new DS-memory-7.X (which will work on Java 11, 17, 21).
   
   You say you have no compile or runtime operations with DS-java 8.X on Java 21.  Have you tried any off-heap or file-mapped memory operations using MemorySegments?
   
   I am a little unclear about your need to run the library on Java 17 vs Java 21 vs Java 25.  Please elaborate.
   
   Also, I don't understand the urgency of providing an Automatic Module Name, which I will be adding, among many other priorities, but what is the urgency?  If your application declares the DS-java jar in its module-info.java file, the system automatically generates a module name based strictly on the JAR's filename.  
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org


Re: [I] Add proper module name in Manifest (datasketches-java)

Posted by "blacelle (via GitHub)" <gi...@apache.org>.
blacelle commented on issue #731:
URL: https://github.com/apache/datasketches-java/issues/731#issuecomment-4197180349

   Hi. We are working into a JDK25 version of our project. Do you have any ETA for this matter @leerho? Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org


Re: [I] Add proper module name in Manifest (datasketches-java)

Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho commented on issue #731:
URL: https://github.com/apache/datasketches-java/issues/731#issuecomment-4607838999

   @blacelle, 
   I don't think you understood my question:
   "You say you have no compile or runtime operations with DS-java 8.X on Java 21. Have you tried any off-heap or file-mapped memory operations using MemorySegments?"
   
   DataSketches-java versions 7.X and 8.X provide the ability to perform / store your sketches off-heap.  In order to do that you have to use one of the constructors that take a Memory object.  Underneath the covers that Memory object leverages the "preview" FFM (MemorySegments) features of Java 21.  Since those preview features are no longer available, your project will likely fail.  If you don't care about using off-heap memory, you will be OK.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org


Re: [I] Add proper module name in Manifest (datasketches-java)

Posted by "leerho (via GitHub) via dev" <de...@datasketches.apache.org>.
leerho commented on issue #731:
URL: https://github.com/apache/datasketches-java/issues/731#issuecomment-6563817571

   This issue has been addressed and is already in main. It will go out on the next release.
   We can close this issue now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org


Re: [I] Add proper module name in Manifest (datasketches-java)

Posted by "blacelle (via GitHub)" <gi...@apache.org>.
blacelle commented on issue #731:
URL: https://github.com/apache/datasketches-java/issues/731#issuecomment-4610061819

   > If you don't care about using off-heap memory, you will be OK.
   
   I use the default setup with respect to memory for DS: I guess we then rely on off-heap memory.
   
   > I realize that DS-java 9.0.1 does not declare an Automatic Module Name. This will be fixed when I can get to it.
   
   Keep to get it. Through, even 9.0.1 seems not available from m2central:  https://mvnrepository.com/artifact/org.apache.datasketches/datasketches-java


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org


Re: [I] Add proper module name in Manifest (datasketches-java)

Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho commented on issue #731:
URL: https://github.com/apache/datasketches-java/issues/731#issuecomment-4607853245

   Also, If you have migrated your application to operate with Java 25, You should download and use DataSketches-java 9.0.1, where using off-heap memory is no longer be a problem.
   
   I realize that DS-java 9.0.1 does not declare an Automatic Module Name. This will be fixed when I can get to it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org


Re: [I] Add proper module name in Manifest (datasketches-java)

Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho commented on issue #731:
URL: https://github.com/apache/datasketches-java/issues/731#issuecomment-4685258979

   I am jut finishing the release of ds-memory 7.0.0.  I will be working on ds-java next.  I am aware of this issue, but the next ds-java releases will take a while.  (Yes, there is not 9.0.1 yet!) :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org


Re: [I] Add proper module name in Manifest (datasketches-java)

Posted by "blacelle (via GitHub)" <gi...@apache.org>.
blacelle commented on issue #731:
URL: https://github.com/apache/datasketches-java/issues/731#issuecomment-4186503368

   > Unfortunately, the DS-Java 7.X does require a preview option.
   
   I understand it requires JDK17 preview option, but they are standard option in JDK21. At the very least, I have no compile or runtime issue with it running a standard JDK21.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org


Re: [I] Add proper module name in Manifest (datasketches-java)

Posted by "blacelle (via GitHub)" <gi...@apache.org>.
blacelle commented on issue #731:
URL: https://github.com/apache/datasketches-java/issues/731#issuecomment-4489704101

   Any news @leerho ? TY


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org


Re: [I] Add proper module name in Manifest (datasketches-java)

Posted by "blacelle (via GitHub)" <gi...@apache.org>.
blacelle commented on issue #731:
URL: https://github.com/apache/datasketches-java/issues/731#issuecomment-4174716203

   Similar report to another library (hoping it help getting the context): https://github.com/fast-pack/JavaFastPFOR/pull/69
   
   > We have several library projects also based on Java, So I think this name should be unique.
   
   Yes, it has to be unique per `.jar`.
   
   > So I think this should be named: org.apache.datasketches-java. Don't you think? 
   
   I tend to agree `org.apache.datasketches-java`  is better, as it follows the maven module naming convention. `org.apache.datasketches` followed a (too quick) look at package names.
   
   In current state, I get at compilation:
   ```
   00:36:58,040 [INFO] org.apache.maven.cli.event.ExecutionEventLogger - --- compiler:3.15.0:compile (default-compile) @ adhoc-encoding ---
   00:36:58,209 [WARNING] org.apache.maven.plugin.compiler.CompilerMojo - ***************************************************************************************************************************************************
   00:36:58,212 [WARNING] org.apache.maven.plugin.compiler.CompilerMojo - * Required filename-based automodules detected: [datasketches-java-7.0.1.jar]. Please don't publish this project to a public artifact repository! *
   00:36:58,212 [WARNING] org.apache.maven.plugin.compiler.CompilerMojo - ***************************************************************************************************************************************************
   ```
   
   > I can add this so it will go into our next release (either a 9.1.0 or a 9.0.1, not sure yet)
   
   Does it mean no hope to get a release with this on 7.X and 8.X branches?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org


Re: [I] Add proper module name in Manifest (datasketches-java)

Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho commented on issue #731:
URL: https://github.com/apache/datasketches-java/issues/731#issuecomment-4184459423

   I can no longer compile 7.0.X and 8.0.X branches because they depend on incubator and preview code, which is no longer available.  These dependencies were early versions of the now released FFM functionality. Which is why you are getting those warnings. Alas, I had no choice at the time, as Oracle blocked access to some of the JVM internals.  
   
   Are you trying to use this code with Slack, by any chance?  
   
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org


Re: [I] Add proper module name in Manifest (datasketches-java)

Posted by "blacelle (via GitHub)" <gi...@apache.org>.
blacelle commented on issue #731:
URL: https://github.com/apache/datasketches-java/issues/731#issuecomment-4598839417

   > Have you tried any off-heap or file-mapped memory operations using MemorySegments?
   
   For now, I'm just considering HLL and KMV.
   
   > I am a little unclear about your need to run the library on Java 17 vs Java 21 vs Java 25. Please elaborate.
   
   I upgraded given project in JDK25. Hence, I could benefit JPMS in DataSketches in JDK21 for bugfix versions, else AutomatedModules in JDK25 would cover most of my needs.
   
   > Also, I don't understand the urgency of providing an Automatic Module Name, which I will be adding, among many other priorities, but what is the urgency?
   
   No urgency as, in the meantime, in order to publish our own project, we had to remove the dependency to DataSketches.
   
   > If your application declares the DS-java jar in its module-info.java file, the system automatically generates a module name based strictly on the JAR's filename.
   
   We integrate DataSketches into a library: automated module-names based on file prevents deployment of the dependant:
   ```
   00:36:58,040 [INFO] org.apache.maven.cli.event.ExecutionEventLogger - --- compiler:3.15.0:compile (default-compile) @ adhoc-encoding ---
   00:36:58,209 [WARNING] org.apache.maven.plugin.compiler.CompilerMojo - ***************************************************************************************************************************************************
   00:36:58,212 [WARNING] org.apache.maven.plugin.compiler.CompilerMojo - * Required filename-based automodules detected: [datasketches-java-7.0.1.jar]. Please don't publish this project to a public artifact repository! *
   00:36:58,212 [WARNING] org.apache.maven.plugin.compiler.CompilerMojo - ***************************************************************************************************************************************************
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org


Re: [I] Add proper module name in Manifest (datasketches-java)

Posted by "leerho (via GitHub) via dev" <de...@datasketches.apache.org>.
leerho closed issue #731: Add proper module name in Manifest
URL: https://github.com/apache/datasketches-java/issues/731


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org


Re: [I] Add proper module name in Manifest (datasketches-java)

Posted by "blacelle (via GitHub)" <gi...@apache.org>.
blacelle commented on issue #731:
URL: https://github.com/apache/datasketches-java/issues/731#issuecomment-4184475006

   > Are you trying to use this code with Slack, by any chance?
   
   Nope. I hit your library to get an HHL and KMV on the shelf.
   
   I was looking for 7.X as would use it in a library based on JDK21 (without preview options).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org


Re: [I] Add proper module name in Manifest (datasketches-java)

Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho commented on issue #731:
URL: https://github.com/apache/datasketches-java/issues/731#issuecomment-4185378172

   Unfortunately, the DS-Java 7.X does require a preview option.
   My recommendation would be for you to migrate to version 9.X (on Java 25), which has no dependencies, pure Java, and is faster.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org


Re: [I] Add proper module name in Manifest (datasketches-java)

Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho commented on issue #731:
URL: https://github.com/apache/datasketches-java/issues/731#issuecomment-4579380858

   Sorry, I have been overwhelmed with family issues and other priorities.  I hope to get to this in the next month or so.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org