You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/03/06 01:07:44 UTC
Re: Review Request 18549: Introduced ABORT_MSG as alternative to fatal.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18549/
-----------------------------------------------------------
(Updated March 5, 2014, 4:07 p.m.)
Review request for mesos and Benjamin Hindman.
Summary (updated)
-----------------
Introduced ABORT_MSG as alternative to fatal.
Bugs: MESOS-1041
https://issues.apache.org/jira/browse/MESOS-1041
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a76021900bf27113fe5b730cfd2b6a537d132
3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 695db20cb1acff036d8d493be4ff4b5e002fdd90
3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 3350929686e5365225f72f48d7c99b42c57fd1ad
Diff: https://reviews.apache.org/r/18549/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 18549: Introduced ABORT_MSG as alternative to fatal.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18549/#review36312
-----------------------------------------------------------
Ship it!
I'm going to commit this now.
- Benjamin Hindman
On March 6, 2014, 12:56 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18549/
> -----------------------------------------------------------
>
> (Updated March 6, 2014, 12:56 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-1041
> https://issues.apache.org/jira/browse/MESOS-1041
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a76021900bf27113fe5b730cfd2b6a537d132
> 3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 695db20cb1acff036d8d493be4ff4b5e002fdd90
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 3350929686e5365225f72f48d7c99b42c57fd1ad
>
> Diff: https://reviews.apache.org/r/18549/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 18549: Introduced ABORT_MSG as alternative to fatal.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18549/
-----------------------------------------------------------
(Updated March 5, 2014, 4:56 p.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-1041
https://issues.apache.org/jira/browse/MESOS-1041
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a76021900bf27113fe5b730cfd2b6a537d132
3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 695db20cb1acff036d8d493be4ff4b5e002fdd90
3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 3350929686e5365225f72f48d7c99b42c57fd1ad
Diff: https://reviews.apache.org/r/18549/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 18549: Introduced ABORT_MSG as alternative to fatal.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18549/
-----------------------------------------------------------
(Updated March 5, 2014, 4:36 p.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-1041
https://issues.apache.org/jira/browse/MESOS-1041
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a76021900bf27113fe5b730cfd2b6a537d132
3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 695db20cb1acff036d8d493be4ff4b5e002fdd90
3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 3350929686e5365225f72f48d7c99b42c57fd1ad
Diff: https://reviews.apache.org/r/18549/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 18549: Introduced ABORT_MSG as alternative to fatal.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18549/#review36301
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp
<https://reviews.apache.org/r/18549/#comment67255>
I don't think this is doing what you want it to do. I think you need another __STRINGIZE.
3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp
<https://reviews.apache.org/r/18549/#comment67256>
No need to print the file and line twice, they should get taken care of by google::LogMessageFatal below.
- Benjamin Hindman
On March 6, 2014, 12:28 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18549/
> -----------------------------------------------------------
>
> (Updated March 6, 2014, 12:28 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-1041
> https://issues.apache.org/jira/browse/MESOS-1041
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a76021900bf27113fe5b730cfd2b6a537d132
> 3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 695db20cb1acff036d8d493be4ff4b5e002fdd90
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 3350929686e5365225f72f48d7c99b42c57fd1ad
>
> Diff: https://reviews.apache.org/r/18549/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 18549: Introduced ABORT_MSG as alternative to fatal.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18549/
-----------------------------------------------------------
(Updated March 5, 2014, 4:28 p.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-1041
https://issues.apache.org/jira/browse/MESOS-1041
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a76021900bf27113fe5b730cfd2b6a537d132
3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 695db20cb1acff036d8d493be4ff4b5e002fdd90
3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 3350929686e5365225f72f48d7c99b42c57fd1ad
Diff: https://reviews.apache.org/r/18549/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 18549: Introduced ABORT_MSG as alternative to fatal.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18549/
-----------------------------------------------------------
(Updated March 5, 2014, 4:13 p.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-1041
https://issues.apache.org/jira/browse/MESOS-1041
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a76021900bf27113fe5b730cfd2b6a537d132
3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 695db20cb1acff036d8d493be4ff4b5e002fdd90
3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 3350929686e5365225f72f48d7c99b42c57fd1ad
Diff: https://reviews.apache.org/r/18549/diff/
Testing
-------
make check
Thanks,
Dominic Hamon