You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by "Bruce Snyder (JIRA)" <ji...@apache.org> on 2008/02/04 18:09:35 UTC
[jira] Commented: (SM-1130) FtpPoller should offer configurable
targetOperation
[ https://issues.apache.org/activemq/browse/SM-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=41220#action_41220 ]
Bruce Snyder commented on SM-1130:
----------------------------------
The attached patch is for the {{FilePollerEndpoint.java}} file in the servicemix-file BC instead of the {{FtpPollerEndpoint.java}} in the servicemix-ftp BC. Please recreate a new patch against the {{FtpPollerEndpoint.java}} file in the servicemix-ftp BC.
> FtpPoller should offer configurable targetOperation
> ---------------------------------------------------
>
> Key: SM-1130
> URL: https://issues.apache.org/activemq/browse/SM-1130
> Project: ServiceMix
> Issue Type: Improvement
> Components: servicemix-ftp
> Affects Versions: 3.1.2
> Reporter: Philippe Pinheiro
> Assignee: Bruce Snyder
> Attachments: SM1130_patch.txt
>
>
> Same issue as for FilePoller : SM-1115
> FtpPoller currently does not use a target operation when sending a message to a target service. The operation must be set, for example, when sending a file to a Ode SU. If not set, Ode throws sort of NPE complaining operation is not set.
> FtpPoller should offer a targetOperation property configurable via XBeans.
> This can be achieved by adding a targetOperation property
> ...
> private QName targetOperation = null;
> ...
> public QName getTargetOperation() { return targetOperation; }
> public void setTargetOperation(QName targetOperation) { this.targetOperation = targetOperation; }
> ...
> protected void processFile(File aFile) throws Exception { ... exchange.setInMessage(message); if (getTargetOperation() != null) exchange.setOperation(getTargetOperation()); // <--- NEW marshaler.readMessage(exchange, message, in, name); ... }
> Then, the SU may be configured properly as follows:
> <f:poller
> service="proj:inbox"
> endpoint="inbox"
> targetService="process:receive"
> targetOperation="process:receive"
> ...
> </f:poller>
> In case the attribute is not set in the xbean.xml, the current behaviour is not changed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (SM-1130) FtpPoller should offer configurable
targetOperation
Posted by jgoodyear <ja...@gmail.com>.
I've updated SM-1130. Sorry about that, generated a diff for the wrong file
- modified FilePollerEndpoint while testing SM-1115 :S
JIRA jira@apache.org wrote:
>
>
> [
> https://issues.apache.org/activemq/browse/SM-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=41220#action_41220
> ]
>
> Bruce Snyder commented on SM-1130:
> ----------------------------------
>
> The attached patch is for the {{FilePollerEndpoint.java}} file in the
> servicemix-file BC instead of the {{FtpPollerEndpoint.java}} in the
> servicemix-ftp BC. Please recreate a new patch against the
> {{FtpPollerEndpoint.java}} file in the servicemix-ftp BC.
>
>> FtpPoller should offer configurable targetOperation
>> ---------------------------------------------------
>>
>> Key: SM-1130
>> URL: https://issues.apache.org/activemq/browse/SM-1130
>> Project: ServiceMix
>> Issue Type: Improvement
>> Components: servicemix-ftp
>> Affects Versions: 3.1.2
>> Reporter: Philippe Pinheiro
>> Assignee: Bruce Snyder
>> Attachments: SM1130_patch.txt
>>
>>
>> Same issue as for FilePoller : SM-1115
>> FtpPoller currently does not use a target operation when sending a
>> message to a target service. The operation must be set, for example, when
>> sending a file to a Ode SU. If not set, Ode throws sort of NPE
>> complaining operation is not set.
>> FtpPoller should offer a targetOperation property configurable via
>> XBeans.
>> This can be achieved by adding a targetOperation property
>> ...
>> private QName targetOperation = null;
>> ...
>> public QName getTargetOperation() { return targetOperation; }
>> public void setTargetOperation(QName targetOperation) {
>> this.targetOperation = targetOperation; }
>> ...
>> protected void processFile(File aFile) throws Exception { ...
>> exchange.setInMessage(message); if (getTargetOperation() != null)
>> exchange.setOperation(getTargetOperation()); // <--- NEW
>> marshaler.readMessage(exchange, message, in, name); ... }
>> Then, the SU may be configured properly as follows:
>> <f:poller
>> service="proj:inbox"
>> endpoint="inbox"
>> targetService="process:receive"
>> targetOperation="process:receive"
>> ...
>> </f:poller>
>> In case the attribute is not set in the xbean.xml, the current behaviour
>> is not changed.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
>
--
View this message in context: http://www.nabble.com/-jira--Commented%3A-%28SM-1130%29-FtpPoller-should-offer-configurable-targetOperation-tp15272620s12049p15277221.html
Sent from the ServiceMix - Dev mailing list archive at Nabble.com.