You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/08/28 07:44:39 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #25604:
[SPARK-28890][SQL] Upgrade Hive Metastore Client to the 3.1.2 for Hive 3.1
HyukjinKwon commented on a change in pull request #25604: [SPARK-28890][SQL] Upgrade Hive Metastore Client to the 3.1.2 for Hive 3.1
URL: https://github.com/apache/spark/pull/25604#discussion_r318435215
##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
##########
@@ -103,7 +103,7 @@ private[hive] object IsolatedClientLoader extends Logging {
case "2.2" | "2.2.0" => hive.v2_2
case "2.3" | "2.3.0" | "2.3.1" | "2.3.2" | "2.3.3" | "2.3.4" | "2.3.5" | "2.3.6" => hive.v2_3
case "3.0" | "3.0.0" => hive.v3_0
- case "3.1" | "3.1.0" | "3.1.1" => hive.v3_1
+ case "3.1" | "3.1.0" | "3.1.1" | "3.1.2" => hive.v3_1
Review comment:
Shall we update:
https://github.com/apache/spark/blob/02a0cdea13a5eebd27649a60d981de35156ba52c/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala#L64-L67
and https://github.com/apache/spark/blob/02a0cdea13a5eebd27649a60d981de35156ba52c/docs/sql-data-sources-hive-tables.md#interacting-with-different-versions-of-hive-metastore
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org