You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2020/09/01 16:05:06 UTC
[Impala-ASF-CR] IMPALA-10071: Impala shouldn't create filename starting with underscore during ACID TRUNCATE
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16396
Change subject: IMPALA-10071: Impala shouldn't create filename starting with underscore during ACID TRUNCATE
......................................................................
IMPALA-10071: Impala shouldn't create filename starting with underscore during ACID TRUNCATE
When Impala TRUNCATEs an ACID table, it creates a new base directory
with the hidden file "_empty" in it. Newer Hive versions ignore files
starting with underscore, therefore they ignore the whole base
directory.
To resolve this issue we can simply rename the empty file to "empty".
Testing:
* update acid-truncate.test accordingly
Change-Id: Ia0557b9944624bc123c540752bbe3877312a7ac9
---
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M testdata/workloads/functional-query/queries/QueryTest/acid-truncate.test
2 files changed, 10 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/16396/1
--
To view, visit http://gerrit.cloudera.org:8080/16396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia0557b9944624bc123c540752bbe3877312a7ac9
Gerrit-Change-Number: 16396
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10071: Impala shouldn't create filename starting with underscore during ACID TRUNCATE
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16396 )
Change subject: IMPALA-10071: Impala shouldn't create filename starting with underscore during ACID TRUNCATE
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16396/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16396/3//COMMIT_MSG@10
PS3, Line 10: Newer Hive versions
> Can you mentions some Hive ticket with more information here?
Sorry, the patch is merged, but the Hive Jira is HIVE-24021.
--
To view, visit http://gerrit.cloudera.org:8080/16396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0557b9944624bc123c540752bbe3877312a7ac9
Gerrit-Change-Number: 16396
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Sep 2020 14:11:30 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10071: Impala shouldn't create filename starting with underscore during ACID TRUNCATE
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16396 )
Change subject: IMPALA-10071: Impala shouldn't create filename starting with underscore during ACID TRUNCATE
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6376/
--
To view, visit http://gerrit.cloudera.org:8080/16396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0557b9944624bc123c540752bbe3877312a7ac9
Gerrit-Change-Number: 16396
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Sep 2020 21:26:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10071: Impala shouldn't create filename starting with underscore during ACID TRUNCATE
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16396 )
Change subject: IMPALA-10071: Impala shouldn't create filename starting with underscore during ACID TRUNCATE
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/7064/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0557b9944624bc123c540752bbe3877312a7ac9
Gerrit-Change-Number: 16396
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Sep 2020 16:25:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10071: Impala shouldn't create filename starting with underscore during ACID TRUNCATE
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16396 )
Change subject: IMPALA-10071: Impala shouldn't create filename starting with underscore during ACID TRUNCATE
......................................................................
IMPALA-10071: Impala shouldn't create filename starting with underscore during ACID TRUNCATE
When Impala TRUNCATEs an ACID table, it creates a new base directory
with the hidden file "_empty" in it. Newer Hive versions ignore files
starting with underscore, therefore they ignore the whole base
directory.
To resolve this issue we can simply rename the empty file to "empty".
Testing:
* update acid-truncate.test accordingly
Change-Id: Ia0557b9944624bc123c540752bbe3877312a7ac9
Reviewed-on: http://gerrit.cloudera.org:8080/16396
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M testdata/workloads/functional-query/queries/QueryTest/acid-truncate.test
2 files changed, 10 insertions(+), 2 deletions(-)
Approvals:
Csaba Ringhofer: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/16396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0557b9944624bc123c540752bbe3877312a7ac9
Gerrit-Change-Number: 16396
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10071: Impala shouldn't create filename starting with underscore during ACID TRUNCATE
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16396 )
Change subject: IMPALA-10071: Impala shouldn't create filename starting with underscore during ACID TRUNCATE
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0557b9944624bc123c540752bbe3877312a7ac9
Gerrit-Change-Number: 16396
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Sep 2020 13:29:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10071: Impala shouldn't create filename starting with underscore during ACID TRUNCATE
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16396 )
Change subject: IMPALA-10071: Impala shouldn't create filename starting with underscore during ACID TRUNCATE
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6376/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/16396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0557b9944624bc123c540752bbe3877312a7ac9
Gerrit-Change-Number: 16396
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Sep 2020 16:06:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10071: Impala shouldn't create filename starting with underscore during ACID TRUNCATE
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16396 )
Change subject: IMPALA-10071: Impala shouldn't create filename starting with underscore during ACID TRUNCATE
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6386/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/16396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0557b9944624bc123c540752bbe3877312a7ac9
Gerrit-Change-Number: 16396
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Sep 2020 08:18:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10071: Impala shouldn't create filename starting with underscore during ACID TRUNCATE
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16396 )
Change subject: IMPALA-10071: Impala shouldn't create filename starting with underscore during ACID TRUNCATE
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
lgtm, if this is what Hive wants
http://gerrit.cloudera.org:8080/#/c/16396/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16396/3//COMMIT_MSG@10
PS3, Line 10: Newer Hive versions
Can you mentions some Hive ticket with more information here?
--
To view, visit http://gerrit.cloudera.org:8080/16396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0557b9944624bc123c540752bbe3877312a7ac9
Gerrit-Change-Number: 16396
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Sep 2020 09:43:00 +0000
Gerrit-HasComments: Yes