[GitHub] [hive] asinkovits commented on a change in pull request #695: HIVE-21909: Publish the LLAP Daemon capacity through ZooKeeper and ho…

[GitBox <gi...@apache.org>]

asinkovits commented on a change in pull request #695: HIVE-21909: Publish the LLAP Daemon capacity through ZooKeeper and ho…
URL: https://github.com/apache/hive/pull/695#discussion_r299871616
 
 

 ##########
 File path: llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapRegistryService.java
 ##########
 @@ -132,6 +136,12 @@ private void unregisterWorker() throws IOException {
     }
   }
 
+  public void updateRegistration(Iterable<Map.Entry<String, String>> attributes) throws IOException {
+    if (isDaemon && this.registry != null) {
 
 Review comment:
   The other register/unregister methods are private and called in serviceStart/serviceStoped only if isDaemon=true.
   Since this new method is public, I wanted to make sure it has the same behaviour. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org